RESOLVED FIXED232657
[WebGPU] Bindings Part 6: Bring back compilation bindings code 
https://bugs.webkit.org/show_bug.cgi?id=232657
Summary [WebGPU] Bindings Part 6: Bring back compilation bindings code
Myles C. Maxfield
Reported 2021-11-03 00:13:41 PDT
[WebGPU] Bindings Part 6: Bring back compilation bindings code
Attachments
Patch (208.55 KB, patch)
2021-11-03 00:19 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (209.19 KB, patch)
2021-11-03 00:31 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-11-03 00:19:10 PDT
Created attachment 443178 [details] Patch
Myles C. Maxfield
Comment 2 2021-11-03 00:31:32 PDT
Created attachment 443179 [details] Patch
Sam Weinig
Comment 3 2021-11-03 09:20:12 PDT
Comment on attachment 443179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review > Source/WebCore/page/Settings.yaml:629 > +WebGPU: Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively.
Myles C. Maxfield
Comment 4 2021-11-03 11:25:31 PDT
Comment on attachment 443179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review >> Source/WebCore/page/Settings.yaml:629 >> +WebGPU: > > Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively. Oh! Okay.
Myles C. Maxfield
Comment 5 2021-11-03 11:25:33 PDT
Comment on attachment 443179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review >> Source/WebCore/page/Settings.yaml:629 >> +WebGPU: > > Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively. Oh! Okay.
Dean Jackson
Comment 6 2021-11-04 09:26:26 PDT
Comment on attachment 443179 [details] Patch rs=me assuming you'll follow Sam's advice.
Myles C. Maxfield
Comment 7 2021-11-06 15:38:29 PDT
Committed r285381 (243938@main): <https://commits.webkit.org/243938@main>
Radar WebKit Bug Importer
Comment 8 2021-11-06 15:39:16 PDT
<rdar://problem/85105149>
Myles C. Maxfield
Comment 9 2021-11-06 17:34:17 PDT
Committed r285388 (243945@main): <https://commits.webkit.org/243945@main>
Note You need to log in before you can comment on or make changes to this bug.