Bug 232657 - [WebGPU] Bindings Part 6: Bring back compilation bindings code
Summary: [WebGPU] Bindings Part 6: Bring back compilation bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-03 00:13 PDT by Myles C. Maxfield
Modified: 2021-11-06 17:34 PDT (History)
18 users (show)

See Also:

Attachments
Patch (208.55 KB, patch)
2021-11-03 00:19 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (209.19 KB, patch)
2021-11-03 00:31 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-03 00:13:41 PDT 
[WebGPU] Bindings Part 6: Bring back compilation bindings code
Comment 1 Myles C. Maxfield 2021-11-03 00:19:10 PDT 
Created attachment 443178 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-03 00:31:32 PDT 
Created attachment 443179 [details]
Patch
Comment 3 Sam Weinig 2021-11-03 09:20:12 PDT 
Comment on attachment 443179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review

> Source/WebCore/page/Settings.yaml:629
> +WebGPU:

Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively.
Comment 4 Myles C. Maxfield 2021-11-03 11:25:31 PDT 
Comment on attachment 443179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review

>> Source/WebCore/page/Settings.yaml:629
>> +WebGPU:
> 
> Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively.

Oh! Okay.
Comment 5 Myles C. Maxfield 2021-11-03 11:25:33 PDT 
Comment on attachment 443179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443179&action=review

>> Source/WebCore/page/Settings.yaml:629
>> +WebGPU:
> 
> Please don’t add any new values to this file, it is deprecated and just here to serve the last few types not yet moved to WTF. Instead, please use the yaml files in WTF exclusively.

Oh! Okay.
Comment 6 Dean Jackson 2021-11-04 09:26:26 PDT 
Comment on attachment 443179 [details]
Patch

rs=me assuming you'll follow Sam's advice.
Comment 7 Myles C. Maxfield 2021-11-06 15:38:29 PDT 
Committed r285381 (243938@main): <https://commits.webkit.org/243938@main>
Comment 8 Radar WebKit Bug Importer 2021-11-06 15:39:16 PDT 
<rdar://problem/85105149>
Comment 9 Myles C. Maxfield 2021-11-06 17:34:17 PDT 
Committed r285388 (243945@main): <https://commits.webkit.org/243945@main>