Bug 232651 - Make scroll bar mode an enum class
Summary: Make scroll bar mode an enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Mouchtaris
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-02 18:48 PDT by Nikos Mouchtaris
Modified: 2021-11-05 16:07 PDT (History)
15 users (show)

See Also:


Attachments
Patch (43.60 KB, patch)
2021-11-02 18:50 PDT, Nikos Mouchtaris
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (43.60 KB, patch)
2021-11-02 22:39 PDT, Nikos Mouchtaris
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (43.53 KB, patch)
2021-11-03 16:18 PDT, Nikos Mouchtaris
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (43.51 KB, patch)
2021-11-03 18:34 PDT, Nikos Mouchtaris
no flags Details | Formatted Diff | Diff
Patch (43.33 KB, patch)
2021-11-05 12:49 PDT, Nikos Mouchtaris
no flags Details | Formatted Diff | Diff
Patch (43.40 KB, patch)
2021-11-05 13:00 PDT, Nikos Mouchtaris
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Mouchtaris 2021-11-02 18:48:39 PDT
Make scroll bar mode an enum class
Comment 1 Nikos Mouchtaris 2021-11-02 18:50:35 PDT
Created attachment 443158 [details]
Patch
Comment 2 Nikos Mouchtaris 2021-11-02 22:39:25 PDT
Created attachment 443175 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-11-03 09:03:10 PDT
Comment on attachment 443175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443175&action=review

> Source/WebCore/page/FrameView.cpp:3525
> +    ScrollbarMode horizonalScrollbarMode = ScrollbarMode::AlwaysOff;
> +    ScrollbarMode verticalScrollbarMode = ScrollbarMode::AlwaysOff;

These could use auto.

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:393
> +    ts.dumpProperty("horizontal scrollbar mode", static_cast<int>(scrollableAreaParameters.horizontalScrollbarMode));
> +    ts.dumpProperty("vertical scrollbar mode", static_cast<int>(scrollableAreaParameters.verticalScrollbarMode));

Ideally you'd fix this by implementing TextStream& operator<<(TextStream& ts, ScrollbarMode)
Comment 4 Nikos Mouchtaris 2021-11-03 16:18:24 PDT
Created attachment 443251 [details]
Patch
Comment 5 Nikos Mouchtaris 2021-11-03 18:34:34 PDT
Created attachment 443265 [details]
Patch
Comment 6 Nikos Mouchtaris 2021-11-05 12:49:03 PDT
Created attachment 443425 [details]
Patch
Comment 7 Nikos Mouchtaris 2021-11-05 13:00:16 PDT
Created attachment 443428 [details]
Patch
Comment 8 EWS 2021-11-05 16:06:57 PDT
Committed r285357 (243916@main): <https://commits.webkit.org/243916@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443428 [details].
Comment 9 Radar WebKit Bug Importer 2021-11-05 16:07:24 PDT
<rdar://problem/85089344>