RESOLVED FIXED232651
Make scroll bar mode an enum class 
https://bugs.webkit.org/show_bug.cgi?id=232651
Summary Make scroll bar mode an enum class
Nikos Mouchtaris
Reported 2021-11-02 18:48:39 PDT
Make scroll bar mode an enum class
Attachments
Patch (43.60 KB, patch)
2021-11-02 18:50 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (43.60 KB, patch)
2021-11-02 22:39 PDT, Nikos Mouchtaris 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (43.53 KB, patch)
2021-11-03 16:18 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (43.51 KB, patch)
2021-11-03 18:34 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (43.33 KB, patch)
2021-11-05 12:49 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (43.40 KB, patch)
2021-11-05 13:00 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikos Mouchtaris
Comment 1 2021-11-02 18:50:35 PDT
Created attachment 443158 [details] Patch
Nikos Mouchtaris
Comment 2 2021-11-02 22:39:25 PDT
Created attachment 443175 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-11-03 09:03:10 PDT
Comment on attachment 443175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443175&action=review > Source/WebCore/page/FrameView.cpp:3525 > + ScrollbarMode horizonalScrollbarMode = ScrollbarMode::AlwaysOff; > + ScrollbarMode verticalScrollbarMode = ScrollbarMode::AlwaysOff; These could use auto. > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:393 > + ts.dumpProperty("horizontal scrollbar mode", static_cast<int>(scrollableAreaParameters.horizontalScrollbarMode)); > + ts.dumpProperty("vertical scrollbar mode", static_cast<int>(scrollableAreaParameters.verticalScrollbarMode)); Ideally you'd fix this by implementing TextStream& operator<<(TextStream& ts, ScrollbarMode)
Nikos Mouchtaris
Comment 4 2021-11-03 16:18:24 PDT
Created attachment 443251 [details] Patch
Nikos Mouchtaris
Comment 5 2021-11-03 18:34:34 PDT
Created attachment 443265 [details] Patch
Nikos Mouchtaris
Comment 6 2021-11-05 12:49:03 PDT
Created attachment 443425 [details] Patch
Nikos Mouchtaris
Comment 7 2021-11-05 13:00:16 PDT
Created attachment 443428 [details] Patch
EWS
Comment 8 2021-11-05 16:06:57 PDT
Committed r285357 (243916@main): <https://commits.webkit.org/243916@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443428 [details].
Radar WebKit Bug Importer
Comment 9 2021-11-05 16:07:24 PDT
<rdar://problem/85089344>
Note You need to log in before you can comment on or make changes to this bug.