Bug 232647 - Remove ReduceLoopStrength
Summary: Remove ReduceLoopStrength
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on:
Blocks: 230908
  Show dependency treegraph
 
Reported: 2021-11-02 17:04 PDT by Justin Michaud
Modified: 2021-11-09 16:05 PST (History)
7 users (show)

See Also:


Attachments
Patch (33.68 KB, patch)
2021-11-02 17:07 PDT, Justin Michaud
justin_michaud: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2021-11-02 17:04:10 PDT
After the introduction of WasmAddress, this pass no longer does anything. It will likely only ever be profitable for WASM, and in addition, the pattern matching is pretty fragile. For now, we should remove it, and consider re-adding it when we need a JetStream progression. Here are some additional thoughts that we should consider before we add it back:

1) We consider hoisting WasmAddress in LICM or as a peephole optimization
2) We should support ARM64: see 230908
3) If we get SIMD/memcpy instruction support, we should consider inlining memcpy
4) We should make the pattern matching more general
Comment 1 Justin Michaud 2021-11-02 17:07:55 PDT
Created attachment 443149 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-11-09 16:05:31 PST
<rdar://problem/85228080>