RESOLVED FIXED232644
[JSC] Add LLInt fast path for OpMod on x86_64 
https://bugs.webkit.org/show_bug.cgi?id=232644
Summary [JSC] Add LLInt fast path for OpMod on x86_64
Ross Kirsling
Reported 2021-11-02 15:21:51 PDT
[JSC] Add LLInt fast path for OpMod on x86_64
Attachments
Patch (4.80 KB, patch)
2021-11-02 15:30 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.56 KB, patch)
2021-11-02 18:16 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2021-11-02 15:30:29 PDT
Created attachment 443140 [details] Patch
Saam Barati
Comment 2 2021-11-02 16:16:23 PDT
Comment on attachment 443140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443140&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1294 > + loadConstantOrVariable(size, t0, t1) > + loadConstantOrVariable(size, t2, t0) > + bqb t0, numberTag, .slow > + bqb t1, numberTag, .slow Maybe loadConstantOrVariableInt32?
Yusuke Suzuki
Comment 3 2021-11-02 16:22:17 PDT
Comment on attachment 443140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443140&action=review r=me too > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1306 > + # Assume t3 is scratchable. > + move t1, t3 > + move t0, t0 > + cdqi > + idivi t3 > + bigteq t0, 0, .notNegZero > + btiz r1, .slow Let's add static_assert with GPRInfo::regTX to ensure that these registers are specific ones. (e.g. regT0 should be eax, and let's comment about r1 is always edx.)
Ross Kirsling
Comment 4 2021-11-02 18:16:46 PDT
Created attachment 443155 [details] Patch for landing
EWS
Comment 5 2021-11-02 20:24:00 PDT
Committed r285197 (243823@main): <https://commits.webkit.org/243823@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443155 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-02 20:24:17 PDT
<rdar://problem/84959127>
Note You need to log in before you can comment on or make changes to this bug.