Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview(). This leaks a UUID object under MRR: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:[[NSUUID alloc] initWithUUIDString:uuid]]);
<rdar://problem/84935290>
Created attachment 443101 [details] Patch v1
Comment on attachment 443101 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review r=me > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 > + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); Could also be: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]);
Comment on attachment 443101 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review >> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 >> + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); > > Could also be: > > auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]); Yep, I found the inline version much harder to parse as a human, which is why I created a separate variable. Thanks for the review!
Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443101 [details].
(In reply to EWS from comment #5) > Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 443101 [details]. Follow-up build fix for internal bots (with newer clang): https://trac.webkit.org/changeset/285229/webkit