RESOLVED FIXED232628
Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview() 
https://bugs.webkit.org/show_bug.cgi?id=232628
Summary Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview()
David Kilzer (:ddkilzer)
Reported 2021-11-02 09:59:52 PDT
Leak of UUID in WebKit::ModelElementController::modelElementDidCreatePreview(). This leaks a UUID object under MRR: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:[[NSUUID alloc] initWithUUIDString:uuid]]);
Attachments
Patch v1 (1.78 KB, patch)
2021-11-02 10:03 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-02 10:00:54 PDT
<rdar://problem/84935290>
David Kilzer (:ddkilzer)
Comment 2 2021-11-02 10:03:16 PDT
Created attachment 443101 [details] Patch v1
Brent Fulgham
Comment 3 2021-11-03 11:17:39 PDT
Comment on attachment 443101 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review r=me > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 > + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); Could also be: auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]);
David Kilzer (:ddkilzer)
Comment 4 2021-11-03 11:21:39 PDT
Comment on attachment 443101 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=443101&action=review >> Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:133 >> + auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:uuid.get()]); > > Could also be: > > auto preview = adoptNS([allocASVInlinePreviewInstance() initWithFrame:CGRectMake(0, 0, size.width(), size.height()) UUID:adoptNS([[NSUUID alloc] initWithUUIDString:uuid]).get()]); Yep, I found the inline version much harder to parse as a human, which is why I created a separate variable. Thanks for the review!
EWS
Comment 5 2021-11-03 11:26:18 PDT
Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443101 [details].
David Kilzer (:ddkilzer)
Comment 6 2021-11-03 14:33:11 PDT
(In reply to EWS from comment #5) > Committed r285217 (243842@main): <https://commits.webkit.org/243842@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 443101 [details]. Follow-up build fix for internal bots (with newer clang): https://trac.webkit.org/changeset/285229/webkit
Note You need to log in before you can comment on or make changes to this bug.