Bug 232609 - [WebGPU] Bindings part 3: Bring back Texture bindings code
Summary: [WebGPU] Bindings part 3: Bring back Texture bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 23:28 PDT by Myles C. Maxfield
Modified: 2021-11-06 14:51 PDT (History)
17 users (show)

See Also:


Attachments
Patch (91.83 KB, patch)
2021-11-01 23:30 PDT, Myles C. Maxfield
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (91.33 KB, patch)
2021-11-02 00:01 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-01 23:28:54 PDT
[WebGPU] Bindings Part 3: Bring back Texture bindings code
Comment 1 Myles C. Maxfield 2021-11-01 23:30:25 PDT
Created attachment 443063 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-02 00:01:15 PDT
Created attachment 443065 [details]
Patch
Comment 3 Myles C. Maxfield 2021-11-02 01:30:31 PDT
Comment on attachment 443065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443065&action=review

> Source/WebCore/Modules/WebGPU/GPUIntegralTypes.h:26
> +#pragma once

#include <cstdint>
Comment 4 Dean Jackson 2021-11-02 10:24:33 PDT
Comment on attachment 443065 [details]
Patch

rs=me

One small comment. Weinig encourages me to put a link to the spec as a comment in the IDL files. I think that's a good idea.
Comment 5 Myles C. Maxfield 2021-11-06 14:50:56 PDT
Committed r285378 (243935@main): <https://commits.webkit.org/243935@main>
Comment 6 Radar WebKit Bug Importer 2021-11-06 14:51:15 PDT
<rdar://problem/85104829>