Bug 232577 – Web Inspector: Display swatch popovers below the swatch by default, not on the left side

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

The popover should be under (or above) the swatch, so it doesn't cover the CSS value it's related to.

More context in https://bugs.webkit.org/show_bug.cgi?id=230065#c4.

[Nikita Vasilyev]

Created attachment 443007 [details]
Patch

[Patrick Angle]

Comment on attachment 443007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443007&action=review

LGTM with the one suggestion to elaborate in the changelog.

> Source/WebInspectorUI/ChangeLog:8
> +        The new defaults are: below, above, left.

Can you just recap the thoughts behind these three choices in this order here (I'm pretty sure I understand all three, particularly since I pushed for Below to come before Above)? It would be nice if we can look back and understand our decisions unlike how we were somewhat left to wonder why the current defaults were the way they are.

[Nikita Vasilyev]

Created attachment 443176 [details]
Patch

[Devin Rousso]

Comment on attachment 443176 [details]
Patch

r=me

[EWS]

Committed r285215 (243840@main): <https://commits.webkit.org/243840@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443176 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84981718>