Bug 232577 - Web Inspector: Display swatch popovers below the swatch by default, not on the left side
Summary: Web Inspector: Display swatch popovers below the swatch by default, not on th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 13:10 PDT by Nikita Vasilyev
Modified: 2021-11-03 10:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2021-11-01 13:40 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2021-11-02 22:57 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2021-11-01 13:10:34 PDT
The popover should be under (or above) the swatch, so it doesn't cover the CSS value it's related to.

More context in https://bugs.webkit.org/show_bug.cgi?id=230065#c4.
Comment 1 Nikita Vasilyev 2021-11-01 13:40:05 PDT
Created attachment 443007 [details]
Patch
Comment 2 Patrick Angle 2021-11-01 20:41:44 PDT
Comment on attachment 443007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443007&action=review

LGTM with the one suggestion to elaborate in the changelog.

> Source/WebInspectorUI/ChangeLog:8
> +        The new defaults are: below, above, left.

Can you just recap the thoughts behind these three choices in this order here (I'm pretty sure I understand all three, particularly since I pushed for Below to come before Above)? It would be nice if we can look back and understand our decisions unlike how we were somewhat left to wonder why the current defaults were the way they are.
Comment 3 Nikita Vasilyev 2021-11-02 22:57:22 PDT
Created attachment 443176 [details]
Patch
Comment 4 Devin Rousso 2021-11-03 10:35:40 PDT
Comment on attachment 443176 [details]
Patch

r=me
Comment 5 EWS 2021-11-03 10:47:16 PDT
Committed r285215 (243840@main): <https://commits.webkit.org/243840@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443176 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-03 10:48:18 PDT
<rdar://problem/84981718>