Bug 232571 - [LFC][IFC] Stop measuring text while collecting inline items when content needs bidi split
Summary: [LFC][IFC] Stop measuring text while collecting inline items when content nee...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 10:37 PDT by zalan
Modified: 2021-11-01 15:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.49 KB, patch)
2021-11-01 10:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2021-11-01 10:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2021-11-01 10:50 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.53 KB, patch)
2021-11-01 14:39 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-11-01 10:37:02 PDT 
bidi boundaries may be different from inline item boundaries.
Comment 1 zalan 2021-11-01 10:41:57 PDT 
Created attachment 442990 [details]
Patch
Comment 2 zalan 2021-11-01 10:45:38 PDT 
Created attachment 442991 [details]
Patch
Comment 3 Antti Koivisto 2021-11-01 10:50:08 PDT 
Comment on attachment 442991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442991&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.h:57
> +    bool hasSeenBiDiContent() const { return !m_paragraphContentBuilder.isEmpty(); }

Lets stay with bidi/Bidi since that is what most of the code uses.
Comment 4 zalan 2021-11-01 10:50:57 PDT 
Created attachment 442993 [details]
Patch
Comment 5 EWS 2021-11-01 14:22:53 PDT 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 6 zalan 2021-11-01 14:39:27 PDT 
Created attachment 443018 [details]
Patch
Comment 7 EWS 2021-11-01 15:09:51 PDT 
Committed r285136 (243775@main): <https://commits.webkit.org/243775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443018 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-01 15:10:21 PDT 
<rdar://problem/84901941>