Bug 232562 - Use Style::ScopeOrdinal for finding the right scope for ::part matching
Summary: Use Style::ScopeOrdinal for finding the right scope for ::part matching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-01 05:36 PDT by Antti Koivisto
Modified: 2021-11-03 04:00 PDT (History)
12 users (show)

See Also:


Attachments
Patch (17.51 KB, patch)
2021-11-01 05:45 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (17.88 KB, patch)
2021-11-01 05:47 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (17.88 KB, patch)
2021-11-01 06:01 PDT, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.88 KB, patch)
2021-11-01 09:15 PDT, Antti Koivisto
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.91 KB, patch)
2021-11-01 09:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (15.54 KB, patch)
2021-11-01 10:46 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch for landing (15.54 KB, patch)
2021-11-03 03:14 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-11-01 05:36:17 PDT
Get rid of the awkward shadowHostInPartRuleScope state.
Comment 1 Antti Koivisto 2021-11-01 05:45:17 PDT
Created attachment 442969 [details]
Patch
Comment 2 Antti Koivisto 2021-11-01 05:47:31 PDT
Created attachment 442970 [details]
Patch
Comment 3 Antti Koivisto 2021-11-01 06:01:30 PDT
Created attachment 442971 [details]
Patch
Comment 4 Antti Koivisto 2021-11-01 09:15:46 PDT
Created attachment 442981 [details]
Patch
Comment 5 Antti Koivisto 2021-11-01 09:53:07 PDT
Created attachment 442986 [details]
Patch
Comment 6 Antti Koivisto 2021-11-01 10:46:38 PDT
Created attachment 442992 [details]
Patch
Comment 7 Simon Fraser (smfr) 2021-11-02 13:18:02 PDT
Comment on attachment 442992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442992&action=review

> Source/WebCore/ChangeLog:8
> +        We are passing the scope ordinal to the selector checker so we can use it consistently to find

are already passing? Or new in this patch?

> Source/WebCore/style/StyleScopeOrdinal.h:51
> +
> +

Extra blank line.
Comment 8 Antti Koivisto 2021-11-03 03:14:42 PDT
Created attachment 443184 [details]
Patch for landing
Comment 9 EWS 2021-11-03 03:59:27 PDT
Committed r285202 (243828@main): <https://commits.webkit.org/243828@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443184 [details].
Comment 10 Radar WebKit Bug Importer 2021-11-03 04:00:21 PDT
<rdar://problem/84968497>