Bug 232550 - [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
Summary: [WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 232541 232549
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-31 15:44 PDT by Myles C. Maxfield
Modified: 2021-11-06 13:51 PDT (History)
22 users (show)

See Also:

Attachments
WIP (105.17 KB, patch)
2021-10-31 15:46 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (105.08 KB, patch)
2021-10-31 15:52 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (109.08 KB, patch)
2021-10-31 16:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (109.23 KB, patch)
2021-10-31 20:10 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (110.58 KB, patch)
2021-10-31 22:36 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (112.08 KB, patch)
2021-10-31 22:45 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (105.26 KB, patch)
2021-10-31 22:57 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (105.83 KB, patch)
2021-10-31 23:03 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (105.92 KB, patch)
2021-10-31 23:21 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP (105.97 KB, patch)
2021-10-31 23:25 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (95.60 KB, patch)
2021-11-01 17:44 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (95.58 KB, patch)
2021-11-01 17:49 PDT, Myles C. Maxfield 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (93.81 KB, patch)
2021-11-04 18:38 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (11) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-10-31 15:44:35 PDT 
[WebGPU] Bindings part 1: Bring back Adapter/Device bindings code
Comment 1 Myles C. Maxfield 2021-10-31 15:46:34 PDT 
Created attachment 442942 [details]
WIP
Comment 2 Myles C. Maxfield 2021-10-31 15:52:40 PDT 
Created attachment 442943 [details]
WIP
Comment 3 Myles C. Maxfield 2021-10-31 16:18:40 PDT 
Created attachment 442944 [details]
WIP
Comment 4 Myles C. Maxfield 2021-10-31 20:10:21 PDT 
Created attachment 442948 [details]
WIP
Comment 5 Myles C. Maxfield 2021-10-31 22:36:48 PDT 
Created attachment 442958 [details]
WIP
Comment 6 Myles C. Maxfield 2021-10-31 22:45:29 PDT 
Created attachment 442960 [details]
WIP
Comment 7 Myles C. Maxfield 2021-10-31 22:57:59 PDT 
Created attachment 442961 [details]
WIP
Comment 8 Myles C. Maxfield 2021-10-31 23:03:08 PDT 
Created attachment 442962 [details]
WIP
Comment 9 Myles C. Maxfield 2021-10-31 23:21:18 PDT 
Created attachment 442963 [details]
WIP
Comment 10 Myles C. Maxfield 2021-10-31 23:25:22 PDT 
Created attachment 442964 [details]
WIP
Comment 11 Myles C. Maxfield 2021-11-01 01:22:37 PDT 
Comment on attachment 442964 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=442964&action=review

> Source/WebCore/Modules/WebGPU/GPUAdapter.h:40
> +    static Ref<GPUAdapter> create(const String& name, Ref<GPUSupportedFeatures>&& features, Ref<GPUSupportedLimits>&& limits, bool isFallbackAdapter)

String&& is probably better.
Comment 12 Myles C. Maxfield 2021-11-01 17:44:52 PDT 
Created attachment 443043 [details]
Patch
Comment 13 Myles C. Maxfield 2021-11-01 17:49:11 PDT 
Created attachment 443044 [details]
Patch
Comment 14 Alex Christensen 2021-11-02 09:31:59 PDT 
Comment on attachment 443044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review

> Source/WebCore/Modules/WebGPU/GPU.cpp:35
> +

nit: extra space

> Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:35
> +

ditto

> Source/WebCore/bindings/scripts/CodeGenerator.pm:198
> -    die "Processing document " . $useDocument->fileName . " did not generate anything.";
> +    # die "Processing document " . $useDocument->fileName . " did not generate anything.";

Don't commit this.
Comment 15 Myles C. Maxfield 2021-11-03 22:59:51 PDT 
Comment on attachment 443044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review

> Source/WebCore/Modules/WebGPU/GPUDevice.h:54
> +    const char* activeDOMObjectName() const final { return "GPUDevice"; }

Private.
Comment 16 Myles C. Maxfield 2021-11-03 23:18:43 PDT 
Comment on attachment 443044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443044&action=review

> Source/WebCore/Modules/WebGPU/GPUDevice.cpp:31
> +GPUDevice::~GPUDevice()

= default
Comment 17 Myles C. Maxfield 2021-11-04 18:38:42 PDT 
Created attachment 443367 [details]
Patch for committing
Comment 18 Myles C. Maxfield 2021-11-06 13:50:57 PDT 
Committed r285376 (243933@main): <https://commits.webkit.org/243933@main>
Comment 19 Radar WebKit Bug Importer 2021-11-06 13:51:18 PDT 
<rdar://problem/85104354>