rdar://83905400
Created attachment 442938 [details] Patch
Is the intention to also enable DOM in GPU Process by default in layout tests?
(In reply to Wenson Hsieh from comment #2) > Is the intention to also enable DOM in GPU Process by default in layout > tests? Good point. It is not, yet.
Created attachment 445449 [details] Patch
Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:954 > +# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely. Nit - let's fix the "relevant" spelling while we're moving this flag
Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 > - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`?
Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review >> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 >> - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') > > Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`? Based on the WTF changelog, It's an internal feature because we've shipped it (on by default) already.
Comment on attachment 445449 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445449&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:162 > + condition: ENABLE(MEDIA_STREAM) Probably we need to add `ENABLE(GPU_PROCESS)` here? > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:959 > + condition: ENABLE(WEB_RTC) Need to add `ENABLE(GPU_PROCESS)` as well?
(In reply to Jonathan Bedard from comment #6) > Comment on attachment 445449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445449&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:-384 > > - options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled') > > Is `WebRTCPlatformCodecsInGPUProcessEnabled` now an internal feature because > it's implicitly part of `UseGPUProcessForDOMRenderingEnabled`? No. It's part of WebRTC, and is enabled by default. I'm moving features we turned on by default in our last release to internal. The flags are useful for testing, but they're no longer experimental.
(In reply to Peng Liu from comment #8) > Comment on attachment 445449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445449&action=review > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:162 > > + condition: ENABLE(MEDIA_STREAM) > > Probably we need to add `ENABLE(GPU_PROCESS)` here? > > > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:959 > > + condition: ENABLE(WEB_RTC) > > Need to add `ENABLE(GPU_PROCESS)` as well? I didn't touch these but can add them.
Created attachment 445764 [details] Patch for landing
Created attachment 445816 [details] Patch for landing
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Created attachment 446000 [details] Patch for landing
Committed r286554 (244884@main): <https://commits.webkit.org/244884@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446000 [details].