Bug 23254 - Upstream page/chromium/
Summary: Upstream page/chromium/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 08:44 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-12 11:25 PST (History)
0 users

See Also:

Attachments
v1 patch (23.11 KB, patch)
2009-01-12 08:57 PST, Darin Fisher (:fishd, Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-12 08:44:49 PST 
Upstream page/chromium/

From here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/page/chromium/
Comment 1 Darin Fisher (:fishd, Google) 2009-01-12 08:57:00 PST 
Created attachment 26634 [details]
v1 patch
Comment 2 Eric Seidel (no email) 2009-01-12 11:14:17 PST 
Comment on attachment 26634 [details]
v1 patch

Shouldn't ChromeClientChromium just be part of ChromeClient?  It seems we should either move that one function to ChromeClient, or at least add a FIXME to do so (or a comment explaining why ChromeClientChromium should be separate).

Also ChromeClientChromium.h uses #ifndef ChromeClientWin

+    // FIXME: To match the macos behaviour we should return DragOperationNone

MacOS or mac os, but macos reads strange to me. :)

+bool DragController::isCopyKeyDown() {

{ on new line

Otherwise looks good.  Sad that chrome doesn't support drag images. :(
Comment 3 Darin Fisher (:fishd, Google) 2009-01-12 11:23:53 PST 
I added a comment to ChromeClientChromium.  That interface exists to hold things that are Chromium-specific.  Right now, that only includes the popupOpened method, which is used to support the Chromium PopupMenu implementation.  I don't think it makes sense to put that on ChromeClient since it isn't useful to other ports.
Comment 4 Darin Fisher (:fishd, Google) 2009-01-12 11:25:55 PST 
http://trac.webkit.org/changeset/39829