Bug 232539 - webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them
Summary: webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-30 21:20 PDT by Brady Eidson
Modified: 2021-11-01 12:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch for EWS (31.64 KB, patch)
2021-10-31 20:30 PDT, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for EWS v2 (31.83 KB, patch)
2021-10-31 21:09 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1 (36.59 KB, patch)
2021-10-31 21:32 PDT, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (37.07 KB, patch)
2021-11-01 11:09 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2021-10-30 21:20:28 PDT 
webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them

Yay API tests.
Comment 1 Brady Eidson 2021-10-31 20:30:42 PDT 
Created attachment 442950 [details]
Patch for EWS
Comment 2 Brady Eidson 2021-10-31 21:09:12 PDT 
Created attachment 442951 [details]
Patch for EWS v2
Comment 3 Brady Eidson 2021-10-31 21:32:47 PDT 
Created attachment 442952 [details]
Patch v1
Comment 4 Brady Eidson 2021-11-01 11:09:41 PDT 
Created attachment 442995 [details]
Patch v2
Comment 5 Alex Christensen 2021-11-01 12:12:08 PDT 
Comment on attachment 442995 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=442995&action=review

> Source/WebKit/webpushd/WebPushDaemon.h:62
> +    HashSet<String> m_inMemoryOriginStringsWithPermissionForTesting;

Why not make this a HashSet<SecurityOriginData>?  That would avoid a lot of conversion back and forth, and it would prevent us from wondering if the String was a valid origin string.
Comment 6 Brady Eidson 2021-11-01 12:18:54 PDT 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 442995 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442995&action=review
> 
> > Source/WebKit/webpushd/WebPushDaemon.h:62
> > +    HashSet<String> m_inMemoryOriginStringsWithPermissionForTesting;
> 
> Why not make this a HashSet<SecurityOriginData>?  That would avoid a lot of
> conversion back and forth, and it would prevent us from wondering if the
> String was a valid origin string.

Forward thinking to "what do we want webpushd to have to link"

Doing that makes it have to link WebCore.

(Happy to revisit that as a more general topic on Slack, figuring out the linking story for these daemons)
Comment 7 EWS 2021-11-01 12:31:52 PDT 
Committed r285121 (243762@main): <https://commits.webkit.org/243762@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442995 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-01 12:32:22 PDT 
<rdar://problem/84894042>