Bug 232539 – webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them

Yay API tests.

[Brady Eidson]

Created attachment 442950 [details]
Patch for EWS

[Brady Eidson]

Created attachment 442951 [details]
Patch for EWS v2

[Brady Eidson]

Created attachment 442952 [details]
Patch v1

[Brady Eidson]

Created attachment 442995 [details]
Patch v2

[Alex Christensen]

Comment on attachment 442995 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=442995&action=review

> Source/WebKit/webpushd/WebPushDaemon.h:62
> +    HashSet<String> m_inMemoryOriginStringsWithPermissionForTesting;

Why not make this a HashSet<SecurityOriginData>?  That would avoid a lot of conversion back and forth, and it would prevent us from wondering if the String was a valid origin string.

[Brady Eidson]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 442995 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442995&action=review
> 
> > Source/WebKit/webpushd/WebPushDaemon.h:62
> > +    HashSet<String> m_inMemoryOriginStringsWithPermissionForTesting;
> 
> Why not make this a HashSet<SecurityOriginData>?  That would avoid a lot of
> conversion back and forth, and it would prevent us from wondering if the
> String was a valid origin string.

Forward thinking to "what do we want webpushd to have to link"

Doing that makes it have to link WebCore.

(Happy to revisit that as a more general topic on Slack, figuring out the linking story for these daemons)

[EWS]

Committed r285121 (243762@main): <https://commits.webkit.org/243762@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442995 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84894042>