Bug 232538 - [LFC][IFC] Add unicode-bidi control characters
Summary: [LFC][IFC] Add unicode-bidi control characters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-30 20:04 PDT by zalan
Modified: 2021-10-31 23:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2021-10-30 20:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.83 KB, patch)
2021-10-31 06:41 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-10-30 20:04:34 PDT 
stub functions only.
Comment 1 zalan 2021-10-30 20:14:09 PDT 
Created attachment 442925 [details]
Patch
Comment 2 Antti Koivisto 2021-10-30 22:46:03 PDT 
Comment on attachment 442925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442925&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:220
>  void InlineItemsBuilder::handleInlineBox(const Box& inlineBox, EnterInlineBox enterInlineBox, InlineItems& inlineItems)

Maybe entering/exiting could be just two separate functions?
Comment 3 zalan 2021-10-31 06:41:39 PDT 
Created attachment 442934 [details]
Patch
Comment 4 EWS 2021-10-31 07:25:51 PDT 
Committed r285093 (243735@main): <https://commits.webkit.org/243735@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442934 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-31 07:26:20 PDT 
<rdar://problem/84856322>
Comment 6 Antti Koivisto 2021-10-31 23:00:01 PDT 
Comment on attachment 442934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442934&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:260
> +    if (enteringContentControlChar)
> +        enterBidiContext(inlineBox, *enteringContentControlChar);
> +    if (nestedContentControlChar)
> +        enterBidiContext(inlineBox, *nestedContentControlChar);

I think these calls could be inside the switch, avoiding the variables.

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:302
> +    if (nestedContentControlChar)
> +        exitBidiContext(inlineBox, *nestedContentControlChar);
> +    if (exitingContentControlChar)
> +        exitBidiContext(inlineBox, *exitingContentControlChar);

Here too.