RESOLVED FIXED232538
[LFC][IFC] Add unicode-bidi control characters 
https://bugs.webkit.org/show_bug.cgi?id=232538
Summary [LFC][IFC] Add unicode-bidi control characters
alan
Reported 2021-10-30 20:04:34 PDT
stub functions only.
Attachments
Patch (6.19 KB, patch)
2021-10-30 20:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.83 KB, patch)
2021-10-31 06:41 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-10-30 20:14:09 PDT
Created attachment 442925 [details] Patch
Antti Koivisto
Comment 2 2021-10-30 22:46:03 PDT
Comment on attachment 442925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442925&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:220 > void InlineItemsBuilder::handleInlineBox(const Box& inlineBox, EnterInlineBox enterInlineBox, InlineItems& inlineItems) Maybe entering/exiting could be just two separate functions?
alan
Comment 3 2021-10-31 06:41:39 PDT
Created attachment 442934 [details] Patch
EWS
Comment 4 2021-10-31 07:25:51 PDT
Committed r285093 (243735@main): <https://commits.webkit.org/243735@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442934 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-31 07:26:20 PDT
<rdar://problem/84856322>
Antti Koivisto
Comment 6 2021-10-31 23:00:01 PDT
Comment on attachment 442934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442934&action=review > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:260 > + if (enteringContentControlChar) > + enterBidiContext(inlineBox, *enteringContentControlChar); > + if (nestedContentControlChar) > + enterBidiContext(inlineBox, *nestedContentControlChar); I think these calls could be inside the switch, avoiding the variables. > Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:302 > + if (nestedContentControlChar) > + exitBidiContext(inlineBox, *nestedContentControlChar); > + if (exitingContentControlChar) > + exitBidiContext(inlineBox, *exitingContentControlChar); Here too.
Note You need to log in before you can comment on or make changes to this bug.