Bug 232537 - Change some bitwise OR operators to logical OR
Summary: Change some bitwise OR operators to logical OR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-30 19:44 PDT by Cameron McCormack (:heycam)
Modified: 2021-10-31 01:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2021-10-30 19:45 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-10-30 19:44:13 PDT 
The std::isfinite() checks that various CanvasRenderingContext2DBase methods do should be using logical OR, not bitwise.
Comment 1 Radar WebKit Bug Importer 2021-10-30 19:44:42 PDT 
<rdar://problem/84845378>
Comment 2 Cameron McCormack (:heycam) 2021-10-30 19:45:50 PDT 
Created attachment 442923 [details]
Patch
Comment 3 EWS 2021-10-31 01:49:25 PDT 
Committed r285091 (243733@main): <https://commits.webkit.org/243733@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442923 [details].