RESOLVED FIXED 23253
[Qt] Build fix after turning the fontCache to a singleton 
https://bugs.webkit.org/show_bug.cgi?id=23253
Summary [Qt] Build fix after turning the fontCache to a singleton
Julien Chaffraix
Reported 2009-01-12 08:41:47 PST
After bug22861, I have broken the build (undefined reference to WebCore::fontCache()). This is an attempt to solve this following zecke's advice to avoid calling fontCache() for the Qt port. Patch forthcoming.
Attachments
Proposed build fix - guard the call against the Qt port (4.49 KB, patch)
2009-01-12 08:47 PST, Julien Chaffraix 		zecke: review-
DetailsFormatted DiffDiff
Build fix: Updated with zecke's comments (1.34 KB, patch)
2009-01-12 13:16 PST, Julien Chaffraix 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2009-01-12 08:47:24 PST
Created attachment 26633 [details] Proposed build fix - guard the call against the Qt port
Holger Freyther
Comment 2 2009-01-12 12:11:00 PST
Comment on attachment 26633 [details] Proposed build fix - guard the call against the Qt port Sorry, my comment in irc was a bit misleading. There is a WebCore/platform/graphics/qt/FontCacheQt.cpp and it needs a fontCache() stub to return a dummy FontCache* instance.
Julien Chaffraix
Comment 3 2009-01-12 13:16:59 PST
Created attachment 26646 [details] Build fix: Updated with zecke's comments
Holger Freyther
Comment 4 2009-01-12 13:24:56 PST
Comment on attachment 26646 [details] Build fix: Updated with zecke's comments looks good.
Julien Chaffraix
Comment 5 2009-01-12 13:32:52 PST
Landed fix in r39832.
Note You need to log in before you can comment on or make changes to this bug.