Migrate the first few callers from ImageBuffer::truncatedLogicalSize() to ImageBUffer::logicalSize()
Created attachment 442907 [details] Patch
<rdar://problem/84836309>
Comment on attachment 442907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442907&action=review > Source/WebCore/ChangeLog:3 > + Migrate the first few callers from ImageBuffer::truncatedLogicalSize() to ImageBUffer::logicalSize() "ImageBuffer::logicalSize()" > Source/WebCore/ChangeLog:10 > + These are the callers which seem obviously correct to migrate from truncatedLogicalSize() to logicalSize(), > + because these are the callers that immediately cast the result to FloatSize. That means, before this patch, > + these callers are going from float -> int -> float. Can you describe in here why we are making this change? I gather it's something like "truncatedLogicalSize() never makes sense, because of XX reasons". And maybe reference bug 225377, like you did in the bug 232515 ChangeLog. > Source/WebKit/ChangeLog:3 > + Migrate the first few callers from ImageBuffer::truncatedLogicalSize() to ImageBUffer::logicalSize() "ImageBuffer::logicalSize()" > Source/WebCore/platform/graphics/filters/FEBlend.cpp:73 > + filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), { { }, imageBuffer->truncatedLogicalSize() }, { CompositeOperator::SourceOver, m_mode }); This is constructing a FloatRect directly now. Did you mean to change this to logicalSize()?
Comment on attachment 442907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442907&action=review >> Source/WebCore/platform/graphics/filters/FEBlend.cpp:73 >> + filterContext.drawImageBuffer(*imageBuffer, drawingRegionOfInputImage(in->absolutePaintRect()), { { }, imageBuffer->truncatedLogicalSize() }, { CompositeOperator::SourceOver, m_mode }); > > This is constructing a FloatRect directly now. Did you mean to change this to logicalSize()? Yep. Will fix.
Created attachment 442924 [details] Patch for committing
Committed r285090 (243732@main): <https://commits.webkit.org/243732@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442924 [details].