Bug 23252 - need a flag to remove the selection rectangle in text controls
Summary: need a flag to remove the selection rectangle in text controls
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-12 07:48 PST by scroggo
Modified: 2010-06-10 16:52 PDT (History)
1 user (show)

See Also:


Attachments
add a flag to remove the selection rectangle in text controls (3.39 KB, patch)
2009-01-12 07:52 PST, scroggo
no flags Details | Formatted Diff | Diff
add a flag to remove the selection rectangle in text controls (3.49 KB, patch)
2009-01-12 08:24 PST, scroggo
adele: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description scroggo 2009-01-12 07:48:09 PST
On the android platform, we draw our own renderer on top of a focused RenderTextControl.  Just like with ENABLE_TEXT_CARET, we want to remove the drawing of the selection rectangle in a RenderTextControl.  This is important because we are multithreaded, and our webkit thread lags behind, so when we remove our renderer, the selection (if any), which is no longer valid, shows up.
Comment 1 scroggo 2009-01-12 07:52:08 PST
Created attachment 26631 [details]
add a flag to remove the selection rectangle in text controls
Comment 2 scroggo 2009-01-12 08:24:30 PST
Created attachment 26632 [details]
add a flag to remove the selection rectangle in text controls

added email address to changelog
Comment 3 Mark Rowe (bdash) 2009-01-12 23:41:49 PST
Do we really need independent defines for every UI quirk that Android has?
Comment 4 Adele Peterson 2009-03-23 11:51:58 PDT
Comment on attachment 26632 [details]
add a flag to remove the selection rectangle in text controls

I agree with Mark.  Its unnecessary to have all these #defines.  One way to do this would be to cause the selection color to be clear in methods like platformActiveSelectionBackgroundColor.  Or you could have RenderTheme/some other platform class provide a way to tell if selection is supported on a particular platform, and you could ask that method before drawing selection.