need a flag to remove the selection rectangle in text controls

On the android platform, we draw our own renderer on top of a focused RenderTextControl.  Just like with ENABLE_TEXT_CARET, we want to remove the drawing of the selection rectangle in a RenderTextControl.  This is important because we are multithreaded, and our webkit thread lags behind, so when we remove our renderer, the selection (if any), which is no longer valid, shows up.

Created attachment 26631 [details]
add a flag to remove the selection rectangle in text controls

Created attachment 26632 [details]
add a flag to remove the selection rectangle in text controls

added email address to changelog

[Mark Rowe (bdash)]

Do we really need independent defines for every UI quirk that Android has?

[Adele Peterson]

Comment on attachment 26632 [details]
add a flag to remove the selection rectangle in text controls

I agree with Mark.  Its unnecessary to have all these #defines.  One way to do this would be to cause the selection color to be clear in methods like platformActiveSelectionBackgroundColor.  Or you could have RenderTheme/some other platform class provide a way to tell if selection is supported on a particular platform, and you could ask that method before drawing selection.

[Ahmad Saleem]

[e-mail] - It was for Android, do we need this anymore? Thanks!

[Ryosuke Niwa]

We're not gonna support Android at this point.