Bug 232516 - [GTK] Remove on-demand hardware acceleration setting
Summary: [GTK] Remove on-demand hardware acceleration setting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency treegraph
 
Reported: 2021-10-29 16:54 PDT by Michael Catanzaro
Modified: 2023-02-01 08:36 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-10-29 16:54:19 PDT
I understand that GTK 4 port requires always-on accelerated compositing mode. Is this correct?

If so, we should remove the setting from public API.
Comment 1 Michael Catanzaro 2022-04-20 05:23:26 PDT
I was planning to remove WebKitHardwareAccelerationPolicy and associated functions altogether. I see Carlos has suggested in bug #125526 that we should maybe not do that after all. Not sure what to do now. Remove only the on demand policy?
Comment 2 Michael Catanzaro 2022-08-23 08:28:18 PDT
Hi Carlos Garcia, hi Alexander, can you discuss and provide a clear answer as to whether we'll still have hardware acceleration policy in the new API version? Alexander was saying as recently as a couple days ago that hardware acceleration is mandatory with GTK 4, but this is contradicted by Carlos's comment in bug #125526. Which is true?

I understand WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND goes away no matter what. The question is whether to continue to provide WEBKIT_HARDWARE_ACCELERATION_POLICY_NEVER or not.
Comment 3 Alice Mikhaylenko 2022-08-23 08:29:51 PDT
I mean as far as I know nonaccelerated doesn't work with GTK4 at least right now? Certainly I wasn't able to switch to it in minibrowser at least a while ago.
Comment 4 Michael Catanzaro 2022-08-23 08:45:13 PDT
Talked to Carlos. Sounds like it *could* work but doesn't. I will plan to remove the API. If somebody implements it, then we can restore the API.
Comment 5 Michael Catanzaro 2022-09-06 06:11:55 PDT
Implemented in bug #244835. So we should only remove the on-demand policy, not the entire API.
Comment 6 Michael Catanzaro 2023-01-31 11:56:14 PST
Pull request: https://github.com/WebKit/WebKit/pull/9398
Comment 7 EWS 2023-02-01 08:36:33 PST
Committed 259686@main (7e5444b964e5): <https://commits.webkit.org/259686@main>

Reviewed commits have been landed. Closing PR #9398 and removing active labels.