Fix a null ptr deref by checking that newOffset is a valid key before adding to the HashMap.
Created attachment 442872 [details] Patch
Created attachment 442873 [details] Patch
Comment on attachment 442873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442873&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Can a test be added for this?
Created attachment 443134 [details] Patch
<rdar://84450793>
Comment on attachment 443134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443134&action=review It looks like the newly added test is failing on test runners. > Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:291 > + if (offsets.isValidKey(newOffset)) { Nit - we generally prefer early returns over multiline if statements like this.
Created attachment 443260 [details] Patch
<rdar://problem/85087814>
This patch is no longer necessary, closing bug.