Bug 232505 - Increase responsiveness timeout for network process
Summary: Increase responsiveness timeout for network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-29 14:32 PDT by Sihui Liu
Modified: 2021-11-01 10:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.47 KB, patch)
2021-10-29 14:38 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (10.89 KB, patch)
2021-10-29 15:10 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (10.87 KB, patch)
2021-11-01 10:04 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-10-29 14:32:25 PDT 
...
Comment 1 Sihui Liu 2021-10-29 14:38:18 PDT 
Created attachment 442864 [details]
Patch
Comment 2 Chris Dumez 2021-10-29 14:41:04 PDT 
Comment on attachment 442864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442864&action=review

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:47
> +    AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds);

Why are you adding a second constructor instead of extending the existing one?

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:204
> +    : AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), 6_s)

Please use a global static constant with a nice name for 6_s.
Comment 3 Sihui Liu 2021-10-29 15:10:43 PDT 
Created attachment 442870 [details]
Patch
Comment 4 Sihui Liu 2021-10-29 15:12:07 PDT 
To help resolve web process crash issue rdar://84745326.
Comment 5 Sihui Liu 2021-10-29 15:12:37 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 442864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442864&action=review
> 
> > Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:47
> > +    AuxiliaryProcessProxy(bool alwaysRunsAtBackgroundPriority, Seconds);
> 
> Why are you adding a second constructor instead of extending the existing
> one?

Removed.

> 
> > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:204
> > +    : AuxiliaryProcessProxy(anyProcessPoolAlwaysRunsAtBackgroundPriority(), 6_s)
> 
> Please use a global static constant with a nice name for 6_s.

Sure.
Comment 6 Chris Dumez 2021-10-29 15:14:27 PDT 
Comment on attachment 442870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442870&action=review

r=me assuming the bots are happy

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:89
> +static const Seconds networkProcessResponsivenessTimeout = 6_s;

constexpr
Comment 7 Sihui Liu 2021-11-01 10:04:36 PDT 
Created attachment 442987 [details]
Patch for landing
Comment 8 EWS 2021-11-01 10:45:43 PDT 
Committed r285115 (243756@main): <https://commits.webkit.org/243756@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442987 [details].
Comment 9 Radar WebKit Bug Importer 2021-11-01 10:46:26 PDT 
<rdar://problem/84888098>