Bug 23247 - createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
Summary: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-11 21:33 PST by Darin Adler
Modified: 2009-01-11 23:49 PST (History)
0 users

See Also:

Attachments
patch (240.96 KB, patch)
2009-01-11 23:15 PST, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2009-01-11 21:33:48 PST 
I noticed this while dealing with unused variable warnings.
Comment 1 Darin Adler 2009-01-11 23:15:04 PST 
Created attachment 26625 [details]
patch
Comment 2 mitz 2009-01-11 23:41:18 PST 
Comment on attachment 26625 [details]
patch

> +        m_path = &temporaryPath;
> +        if (!parseSVG(d, true))
> +            return false;

Leaving m_path pointing at a temporary is scary, but not new to this patch.

r=me
Comment 3 Darin Adler 2009-01-11 23:49:14 PST 
http://trac.webkit.org/changeset/39819