Bug 232460 – Layout test is crashing inside WebChromeClient::createWindow

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

The test fast/frames/sandboxed-iframe-close-top-noclose.html is crashing under WebChromeClient::createWindow.

[Per Arne Vollan]

<rdar://81344393>

[Per Arne Vollan]

Created attachment 442755 [details]
Patch

[Brent Fulgham]

Comment on attachment 442755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442755&action=review

r=me

> Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm:315
> +        if (hostProxy && !hostProxy->isMenuBarVisible()) {

Should we log something when we have a set of plugin hosts with no host?

Should we remove the m_pluginHosts entry if the value is nil?

[Per Arne Vollan]

Created attachment 442761 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 442755 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442755&action=review
> 
> r=me
> 
> > Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostManager.mm:315
> > +        if (hostProxy && !hostProxy->isMenuBarVisible()) {
> 
> Should we log something when we have a set of plugin hosts with no host?
> 
> Should we remove the m_pluginHosts entry if the value is nil?

That is a good point. I have added logging in the latest patch. It would also be good to remove the items with nil value, although I did not include that in the latest patch, since there could possibly be side effects from doing that.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 442775 [details]
Patch

[EWS]

Committed r285018 (243662@main): <https://commits.webkit.org/243662@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442775 [details].