Bug 232443 - [webkitscmpy] Fix commits set on branch
Summary: [webkitscmpy] Fix commits set on branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-28 10:27 PDT by Jonathan Bedard
Modified: 2021-10-28 14:04 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2021-10-28 10:32 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2021-10-28 12:38 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2021-10-28 13:30 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-10-28 10:27:48 PDT 
When we are grabbing a set of commits on a branch, the current code returns incorrect identifiers for those commits in git.
Comment 1 Radar WebKit Bug Importer 2021-10-28 10:28:02 PDT 
<rdar://problem/84763432>
Comment 2 Jonathan Bedard 2021-10-28 10:32:22 PDT 
Created attachment 442717 [details]
Patch
Comment 3 Darin Adler 2021-10-28 12:06:28 PDT 
Comment on attachment 442717 [details]
Patch

Do we have a way to test this?
Comment 4 Jonathan Bedard 2021-10-28 12:20:04 PDT 
Pull-request: https://github.com/WebKit/WebKit/pull/26
Comment 5 Jonathan Bedard 2021-10-28 12:36:55 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 442717 [details]
> Patch
> 
> Do we have a way to test this?

Went back to double-check, and yes.  Our existing tests almost caught it in the first place (they needed 3 commits on a branch instead of 2)
Comment 6 Jonathan Bedard 2021-10-28 12:38:17 PDT 
Created attachment 442731 [details]
Patch
Comment 7 Jonathan Bedard 2021-10-28 13:30:00 PDT 
Created attachment 442737 [details]
Patch
Comment 8 EWS 2021-10-28 14:04:45 PDT 
Committed r285002 (243648@main): <https://commits.webkit.org/243648@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442737 [details].