Bug 232438 - Add stubs for the Web Locks API
Summary: Add stubs for the Web Locks API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 232436
  Show dependency treegraph
 
Reported: 2021-10-28 09:38 PDT by Chris Dumez
Modified: 2021-10-28 18:05 PDT (History)
15 users (show)

See Also:


Attachments
Patch (126.46 KB, patch)
2021-10-28 09:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (131.98 KB, patch)
2021-10-28 13:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (132.96 KB, patch)
2021-10-28 15:31 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-10-28 09:38:52 PDT
Add stubs for the Web Locks API:
- https://wicg.github.io/web-locks/#api
Comment 1 Chris Dumez 2021-10-28 09:40:44 PDT
Created attachment 442711 [details]
Patch
Comment 2 Chris Dumez 2021-10-28 13:55:00 PDT
Created attachment 442740 [details]
Patch
Comment 3 Chris Dumez 2021-10-28 15:31:08 PDT
Created attachment 442752 [details]
Patch
Comment 4 Geoffrey Garen 2021-10-28 17:03:47 PDT
Comment on attachment 442752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review

r=me

> Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27
> +    SecureContext

This seems like an arbitrary restriction, but I imagine it's required by the spec?
Comment 5 Chris Dumez 2021-10-28 17:31:09 PDT
Comment on attachment 442752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442752&action=review

>> Source/WebCore/Modules/web-locks/NavigatorLocks.idl:27
>> +    SecureContext
> 
> This seems like an arbitrary restriction, but I imagine it's required by the spec?

Yes, this is per spec. A lot of the new APIs are only exposed to secure contexts.
Comment 6 EWS 2021-10-28 18:04:49 PDT
Committed r285012 (243658@main): <https://commits.webkit.org/243658@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442752 [details].
Comment 7 Radar WebKit Bug Importer 2021-10-28 18:05:28 PDT
<rdar://problem/84787791>