Bug 232414 - Don't call type() on Structure, instead call type() on its typeInfo()
Summary: Don't call type() on Structure, instead call type() on its typeInfo()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-27 18:03 PDT by Saam Barati
Modified: 2021-10-28 14:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2021-10-27 19:31 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (4.84 KB, patch)
2021-10-27 19:53 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (4.84 KB, patch)
2021-10-28 09:56 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-10-27 18:03:38 PDT 
...
Comment 1 Saam Barati 2021-10-27 19:31:26 PDT 
Created attachment 442666 [details]
Patch
Comment 2 Yusuke Suzuki 2021-10-27 19:41:53 PDT 
Comment on attachment 442666 [details]
Patch

r=me
I also found several other places `structure->type() == JSType::ArrayType` in DFGOperations.cpp. Can you fix it too?
Comment 3 Saam Barati 2021-10-27 19:53:03 PDT 
Created attachment 442668 [details]
patch for landing
Comment 4 Saam Barati 2021-10-28 09:56:39 PDT 
Created attachment 442713 [details]
patch for landing
Comment 5 EWS 2021-10-28 14:22:42 PDT 
Committed r285004 (243650@main): <https://commits.webkit.org/243650@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442713 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-28 14:23:19 PDT 
<rdar://problem/84778008>