RESOLVED FIXED232414
Don't call type() on Structure, instead call type() on its typeInfo() 
https://bugs.webkit.org/show_bug.cgi?id=232414
Summary Don't call type() on Structure, instead call type() on its typeInfo()
Saam Barati
Reported 2021-10-27 18:03:38 PDT
...
Attachments
Patch (2.48 KB, patch)
2021-10-27 19:31 PDT, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (4.84 KB, patch)
2021-10-27 19:53 PDT, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (4.84 KB, patch)
2021-10-28 09:56 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-10-27 19:31:26 PDT
Created attachment 442666 [details] Patch
Yusuke Suzuki
Comment 2 2021-10-27 19:41:53 PDT
Comment on attachment 442666 [details] Patch r=me I also found several other places `structure->type() == JSType::ArrayType` in DFGOperations.cpp. Can you fix it too?
Saam Barati
Comment 3 2021-10-27 19:53:03 PDT
Created attachment 442668 [details] patch for landing
Saam Barati
Comment 4 2021-10-28 09:56:39 PDT
Created attachment 442713 [details] patch for landing
EWS
Comment 5 2021-10-28 14:22:42 PDT
Committed r285004 (243650@main): <https://commits.webkit.org/243650@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442713 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-28 14:23:19 PDT
<rdar://problem/84778008>
Note You need to log in before you can comment on or make changes to this bug.