WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23237
Some HTML constructors in HTMLElementFactory needs an HTMLFormElement argument
https://bugs.webkit.org/show_bug.cgi?id=23237
Summary
Some HTML constructors in HTMLElementFactory needs an HTMLFormElement argument
Julien Chaffraix
Reported
2009-01-11 05:46:10 PST
This is required to generate HTMLElementFactory. Patch forthcoming.
Attachments
Proposed fix: add a new parameter to make_names
(9.02 KB, patch)
2009-01-11 05:49 PST
,
Julien Chaffraix
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2009-01-11 05:49:15 PST
Created
attachment 26604
[details]
Proposed fix: add a new parameter to make_names
Darin Adler
Comment 2
2009-01-11 09:00:02 PST
Comment on
attachment 26604
[details]
Proposed fix: add a new parameter to make_names r=me I think the "=1" in the syntax aren't so great. constructorNeedsCreatedByParser=1 should just be constructorNeedsCreatedByParser and constructorNeedsFormElement=1 should just be constructorNeedsFormElement
Julien Chaffraix
Comment 3
2009-01-16 13:40:46 PST
Landed patch in
r39982
.
> I think the "=1" in the syntax aren't so great. > constructorNeedsCreatedByParser=1 should just be > constructorNeedsCreatedByParser and constructorNeedsFormElement=1 should just > be constructorNeedsFormElement
Right, I guess I could tune the .in parser a bit so that we can have this syntax.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug