Bug 232360 – [WebKit] Enable -Wformat=2 warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

Enable -Wformat=2 warnings in the WebKit project.

This includes -Wformat-nonliteral among other warnings.

<rdar://problem/84571460>

[David Kilzer (:ddkilzer)]

Created attachment 442559 [details]
Patch v1

[Darin Adler]

Comment on attachment 442559 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=442559&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:98
> +    NSString *const format = @"Experimental%@";

Consider constexpr.

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:100
> +    NSString *const format = @"WebKitExperimental%@";

Consider constexpr.

> Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm:56
>      _LSSetApplicationInformationItem(kLSDefaultSessionID, _LSGetCurrentApplicationASN(), _kLSDisplayNameKey, (CFStringRef)applicationName, nullptr);

bridge_cast?

[David Kilzer (:ddkilzer)]

Applying all of these changes.  Thanks!

[David Kilzer (:ddkilzer)]

Created attachment 442659 [details]
Patch for landing

[David Kilzer (:ddkilzer)]

Comment on attachment 442659 [details]
Patch for landing

Marking cq+ since "Patch v1" passed, and this doesn't include any substantive changes.

[EWS]

Committed r284968 (243619@main): <https://commits.webkit.org/243619@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442659 [details].