Bug 232358 – [ANGLE] Enable -Wformat=2 warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[David Kilzer (:ddkilzer)]

Enable -Wformat=2 warnings in the ANGLE project.

This includes -Wformat-nonliteral among other warnings.

<rdar://problem/84568935>

[David Kilzer (:ddkilzer)]

Created attachment 442555 [details]
Patch v1

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

It would be most beneficial to add this upstream in ANGLE in https://chromium.googlesource.com/angle/angle . We're actively in the process of upstreaming all of Apple's changes in preparation for taking a new ANGLE snapshot.

Kyle (CC'd) can also help with this.

[David Kilzer (:ddkilzer)]

(In reply to Kenneth Russell from comment #3)
> It would be most beneficial to add this upstream in ANGLE in
> https://chromium.googlesource.com/angle/angle . We're actively in the
> process of upstreaming all of Apple's changes in preparation for taking a
> new ANGLE snapshot.
> 
> Kyle (CC'd) can also help with this.

Yep, I filed <https://bugs.chromium.org/p/angleproject/issues/detail?id=6623> to track upstreaming.  It’s in the See Also field as well.

[David Kilzer (:ddkilzer)]

Created attachment 442661 [details]
Patch v2

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #5)
> Created attachment 442661 [details]
> Patch v2

Use `constexpr const char *` instead of `const char *const`.

[David Kilzer (:ddkilzer)]

Adding Simon and Jon since I don't know who's reviewing ANGLE patches these days.

This is a pretty simple patch.

[EWS]

Committed r285102 (243744@main): <https://commits.webkit.org/243744@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442661 [details].