Bug 232354 - webkitdirs.pm should use JSON::XS when available
Summary: webkitdirs.pm should use JSON::XS when available
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 17:04 PDT by Alexey Proskuryakov
Modified: 2021-10-27 08:30 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.35 KB, patch)
2021-10-26 17:08 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2021-10-26 17:04:42 PDT 
JSON::XS is faster than JSON::PP. While it doesn't matter for webkitdirs' own use, where JSONs are tiny, other scripts that import webkitdirs.pm do care.
Comment 1 Alexey Proskuryakov 2021-10-26 17:08:05 PDT 
Created attachment 442544 [details]
proposed patch

It's intentional that the script doesn't die if import fails - there is a lot of functionality that doesn't require JSON, so it's better to not break everything even in the super unlikely case that JSON::PP cannot be loaded.
Comment 2 dewei_zhu 2021-10-26 17:48:14 PDT 
Comment on attachment 442544 [details]
proposed patch

rme
Comment 3 EWS 2021-10-27 08:29:59 PDT 
Committed r284922 (243593@main): <https://commits.webkit.org/243593@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442544 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-27 08:30:26 PDT 
<rdar://problem/84710691>