Bug 232352 - Store WPT-style fuzzy pixel matching data in ImageDiffResult
Summary: Store WPT-style fuzzy pixel matching data in ImageDiffResult
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 232365
  Show dependency tree / graph
 
Reported: 2021-10-26 16:42 PDT by Simon Fraser (smfr)
Modified: 2021-10-27 11:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.15 KB, patch)
2021-10-26 16:43 PDT, Simon Fraser (smfr) 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-26 16:42:40 PDT 
Store WPT-style fuzzy pixel matching data in ImageDiffResult
Comment 1 Simon Fraser (smfr) 2021-10-26 16:43:49 PDT 
Created attachment 442542 [details]
Patch
Comment 2 Martin Robinson 2021-10-27 03:48:42 PDT 
Comment on attachment 442542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442542&action=review

> Tools/Scripts/webkitpy/port/image_diff.py:147
> +        m = re.match(b'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data)

I think this should be:
    
m = re.match(br'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data)

which is the source of the style bot failure.
Comment 3 Simon Fraser (smfr) 2021-10-27 11:19:36 PDT 
https://trac.webkit.org/changeset/284930/webkit
Comment 4 Radar WebKit Bug Importer 2021-10-27 11:20:18 PDT 
<rdar://problem/84719334>