Bug 232336 – WKAPI does not have any APIs to set cookie path to WKWebsiteDataStoreConfigurationRef

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Takashi Komori]

WKAPI doesn't have any APIs for setting cookie DB location to WKWebsiteDataStoreConfigurationRef.

[Takashi Komori]

Created attachment 442537 [details]
Patch

[Takashi Komori]

Created attachment 442538 [details]
Patch

[Alex Christensen]

Comment on attachment 442538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442538&action=review

This is reasonable but the test needs some love.

> Tools/TestWebKitAPI/PlatformPlayStation.cmake:33
> +        Tests/WebKit/curl/CookieStorageFile.cpp

There's nothing curl-specific about this test.

> Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:76
> +    WKPageConfigurationSetContext(pageConfiguration.get(), context.get());

This doesn't do anything.

> Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:84
> +    loaderClient.base.clientInfo = this;

Instead of using a static bool didFinishLoad, use a local bool didFinishLoad and point clientInfo at it.  Or put m_didFinishLoad in the CookieStorageFile class.

[Takashi Komori]

Created attachment 442770 [details]
Patch

[Takashi Komori]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 442538 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442538&action=review
> 
> This is reasonable but the test needs some love.
> 
> > Tools/TestWebKitAPI/PlatformPlayStation.cmake:33
> > +        Tests/WebKit/curl/CookieStorageFile.cpp
> 
> There's nothing curl-specific about this test.

Moved the test to Tests/WebKit/ directory.

> > Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:76
> > +    WKPageConfigurationSetContext(pageConfiguration.get(), context.get());
> 
> This doesn't do anything.

On WinCairo port, the WebKit::WebView constructor uses the context which is set by WKPageConfigurationSetContext.
Therefore, it is necessary.

Source/WebKit/UIProcess/win/WebView.cpp

> > Tools/TestWebKitAPI/Tests/WebKit/curl/CookieStorageFile.cpp:84
> > +    loaderClient.base.clientInfo = this;
> 
> Instead of using a static bool didFinishLoad, use a local bool didFinishLoad
> and point clientInfo at it.  Or put m_didFinishLoad in the CookieStorageFile
> class.

Fixed.

[Takashi Komori]

Created attachment 442786 [details]
Patch for landing

[EWS]

Committed r285020 (243664@main): <https://commits.webkit.org/243664@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442786 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84798584>