Bug 232329 - [macOS][GPUP] Remove access to sysctl properties
Summary: [macOS][GPUP] Remove access to sysctl properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 13:46 PDT by Per Arne Vollan
Modified: 2021-11-10 12:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.78 KB, patch)
2021-10-26 13:48 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-10-26 13:46:19 PDT 
Based on telemetry, remove access to unused sysctl properties in the GPU process' sandbox on macOS.
Comment 1 Radar WebKit Bug Importer 2021-10-26 13:46:53 PDT 
<rdar://problem/84679628>
Comment 2 Per Arne Vollan 2021-10-26 13:48:36 PDT 
Created attachment 442527 [details]
Patch
Comment 3 Darin Adler 2021-10-26 13:56:14 PDT 
Comment on attachment 442527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442527&action=review

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:173
> -(deny sysctl*)
> +(deny sysctl* (with telemetry))

This change is not mentioned in the change log. What’s the rationale?
Comment 4 Per Arne Vollan 2021-10-26 14:04:02 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 442527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442527&action=review
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:173
> > -(deny sysctl*)
> > +(deny sysctl* (with telemetry))
> 
> This change is not mentioned in the change log. What’s the rationale?

This is to get telemetry for sysctl properties we might need to add in the future when new features being are added to the GPU process.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-11-10 12:26:31 PST 
Comment on attachment 442527 [details]
Patch

Thanks for reviewing!
Comment 6 EWS 2021-11-10 12:30:13 PST 
Committed r285606 (244110@main): <https://commits.webkit.org/244110@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442527 [details].