Bug 232312 - [ iOS Release GPUProcess ] fast/forms/form-submission-crash-3.html is a flaky failure
Summary: [ iOS Release GPUProcess ] fast/forms/form-submission-crash-3.html is a flaky...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 09:42 PDT by ayumi_kojima
Modified: 2021-10-27 11:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2021-10-26 10:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-10-26 09:42:46 PDT
fast/forms/form-submission-crash-3.html

Is a flaky failure on iOS 15 Release (mostly on gpuprocyess)

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fform-submission-crash-3.html

Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r284857%20(317)/results.html#

Diff:

--- /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/fast/forms/form-submission-crash-3-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/fast/forms/form-submission-crash-3-actual.txt
@@ -8,6 +8,5 @@
 
 TEST COMPLETE
 
-foo
Comment 1 Radar WebKit Bug Importer 2021-10-26 09:43:10 PDT
<rdar://problem/84667412>
Comment 2 ayumi_kojima 2021-10-26 09:43:50 PDT
I was able to reproduce the failure locally on iOS 15 sim on arm64 using run-webkit-tests --ios-simulator --iterations 500 --exit-after-n-failures 1 fast/forms/form-submission-crash-3.html --use-gpu-process
Comment 3 Chris Dumez 2021-10-26 10:07:58 PDT
```
    input.onfocus = eventhandler;
    button.click();
    testPassed('if not crashed.');
    finishJSTest();
```

I think this means eventhandler has not had a change to run before we call finishJSTest(), which must mean that the onfocus event handler wasn't called synchronously when clicking the button.

I am not sure what the rules for focus are nowadays and if that event is really supposed to fire synchronously. If not, I guess we want to delay calling finishJSTest() until the focus event has fired.

Alternatively, we could mark div1 as display:none.
Comment 4 Chris Dumez 2021-10-26 10:13:24 PDT
Created attachment 442503 [details]
Patch
Comment 5 EWS 2021-10-27 11:30:36 PDT
Committed r284933 (243603@main): <https://commits.webkit.org/243603@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442503 [details].