Bug 232311 - [AppSSO] Avoid attempting to display a nil view controller
Summary: [AppSSO] Avoid attempting to display a nil view controller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 09:29 PDT by Brent Fulgham
Modified: 2021-10-26 14:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2021-10-26 09:33 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-10-26 09:29:11 PDT 
Crash logs indicate that it is possible for the delegate for an AppSSO authentication to get called after the view has been dismissed (e.g., when a user grows impatient with a slow authentication).

Rather than crashing, we should clean up the session state and make it ready for a new attempt.
Comment 1 Brent Fulgham 2021-10-26 09:29:57 PDT 
<rdar://problem/55199117>
Comment 2 Brent Fulgham 2021-10-26 09:33:46 PDT 
Created attachment 442499 [details]
Patch
Comment 3 EWS 2021-10-26 14:13:08 PDT 
Committed r284896 (243573@main): <https://commits.webkit.org/243573@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442499 [details].