Bug 232305 - build broken on ubuntu 18.04
Summary: build broken on ubuntu 18.04
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-26 08:24 PDT by Daniel Kolesa
Modified: 2021-11-01 01:43 PDT (History)
3 users (show)

See Also:


Attachments
patch (3.79 KB, patch)
2021-10-26 08:25 PDT, Daniel Kolesa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kolesa 2021-10-26 08:24:27 PDT
The 18.04 builder has been broken for a while https://build.webkit.org/#/builders/71 because of a compiler ICE.
Comment 1 Daniel Kolesa 2021-10-26 08:25:57 PDT
Created attachment 442492 [details]
patch

This is a workaround that gets over the segfault. It should not affect other compilers.
Comment 2 Alexey Proskuryakov 2021-10-26 08:58:48 PDT
Comment on attachment 442492 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442492&action=review

> Source/WebCore/ChangeLog:12
> +        Thes sections of the code trigger an internal compiler error with
> +        GCC 8.4, segfaulting the compiler. This adds a workaround that
> +        makes it work again.

Could you please post the gcc bug report link here?
Comment 3 Daniel Kolesa 2021-10-26 09:03:08 PDT
I'm not aware of a GCC bug report yet, this is a new issue (the WeakPtr refactoring is recent)

There is GCC 8.5 already, but ubuntu 18.04 does not ship with it (it would be good to test if the problem still happens in 8.5)
Comment 4 Daniel Kolesa 2021-10-26 09:08:00 PDT
that said, the .5 release tends to be the last one, so I'd expect there won't be any more gcc 8 fixes either way
Comment 5 Daniel Kolesa 2021-10-26 09:09:42 PDT
indeed, there is no more development in the gcc8 branch: https://github.com/gcc-mirror/gcc/commits/releases/gcc-8
Comment 6 EWS 2021-11-01 01:42:27 PDT
Committed r285101 (243743@main): <https://commits.webkit.org/243743@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442492 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-01 01:43:23 PDT
<rdar://problem/84873634>