RESOLVED FIXED 232305
build broken on ubuntu 18.04 
https://bugs.webkit.org/show_bug.cgi?id=232305
Summary build broken on ubuntu 18.04
Daniel Kolesa
Reported 2021-10-26 08:24:27 PDT
The 18.04 builder has been broken for a while https://build.webkit.org/#/builders/71 because of a compiler ICE.
Attachments
patch (3.79 KB, patch)
2021-10-26 08:25 PDT, Daniel Kolesa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Kolesa
Comment 1 2021-10-26 08:25:57 PDT
Created attachment 442492 [details] patch This is a workaround that gets over the segfault. It should not affect other compilers.
Alexey Proskuryakov
Comment 2 2021-10-26 08:58:48 PDT
Comment on attachment 442492 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=442492&action=review > Source/WebCore/ChangeLog:12 > + Thes sections of the code trigger an internal compiler error with > + GCC 8.4, segfaulting the compiler. This adds a workaround that > + makes it work again. Could you please post the gcc bug report link here?
Daniel Kolesa
Comment 3 2021-10-26 09:03:08 PDT
I'm not aware of a GCC bug report yet, this is a new issue (the WeakPtr refactoring is recent) There is GCC 8.5 already, but ubuntu 18.04 does not ship with it (it would be good to test if the problem still happens in 8.5)
Daniel Kolesa
Comment 4 2021-10-26 09:08:00 PDT
that said, the .5 release tends to be the last one, so I'd expect there won't be any more gcc 8 fixes either way
Daniel Kolesa
Comment 5 2021-10-26 09:09:42 PDT
indeed, there is no more development in the gcc8 branch: https://github.com/gcc-mirror/gcc/commits/releases/gcc-8
EWS
Comment 6 2021-11-01 01:42:27 PDT
Committed r285101 (243743@main): <https://commits.webkit.org/243743@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442492 [details].
Radar WebKit Bug Importer
Comment 7 2021-11-01 01:43:23 PDT
<rdar://problem/84873634>
Note You need to log in before you can comment on or make changes to this bug.