Bug 232298 - AX: AXValueChanged is only sent for range elements when value is changed with the keyboard
Summary: AX: AXValueChanged is only sent for range elements when value is changed with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 232300
  Show dependency tree / graph
 
Reported: 2021-10-26 01:53 PDT by Carlos Garcia Campos
Modified: 2021-10-31 07:43 PDT (History)
15 users (show)

See Also:

Attachments
Patch (8.92 KB, patch)
2021-10-26 01:56 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (8.92 KB, patch)
2021-10-26 02:43 PDT, Carlos Garcia Campos 		andresg_22: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-10-26 01:53:05 PDT 
It should always be sent when the value changes.
Comment 1 Radar WebKit Bug Importer 2021-10-26 01:53:18 PDT 
<rdar://problem/84653767>
Comment 2 Carlos Garcia Campos 2021-10-26 01:56:53 PDT 
Created attachment 442473 [details]
Patch
Comment 3 Carlos Garcia Campos 2021-10-26 02:43:06 PDT 
Created attachment 442474 [details]
Patch
Comment 4 Andres Gonzalez 2021-10-27 08:25:45 PDT 
(In reply to Carlos Garcia Campos from comment #3)
> Created attachment 442474 [details]
> Patch

Good fix. Does this tes pass in isolated tree mode? I would think we need to modify the test to wait for the value to be updated in the isolated tree.
Comment 5 Carlos Garcia Campos 2021-10-28 01:34:06 PDT 
(In reply to Andres Gonzalez from comment #4)
> (In reply to Carlos Garcia Campos from comment #3)
> > Created attachment 442474 [details]
> > Patch
> 
> Good fix. Does this tes pass in isolated tree mode? I would think we need to
> modify the test to wait for the value to be updated in the isolated tree.

It works with a patch similar to the one attached to bug #232141. I'm still not sure it's worth rewriting all the tests to make them async when we can just notify earlier about property changes.
Comment 6 Carlos Garcia Campos 2021-10-28 01:36:46 PDT 
Committed r284972 (243622@main): <https://commits.webkit.org/243622@main>
Comment 7 Andres Gonzalez 2021-10-31 07:43:45 PDT 
(In reply to Carlos Garcia Campos from comment #5)
> (In reply to Andres Gonzalez from comment #4)
> > (In reply to Carlos Garcia Campos from comment #3)
> > > Created attachment 442474 [details]
> > > Patch
> > 
> > Good fix. Does this tes pass in isolated tree mode? I would think we need to
> > modify the test to wait for the value to be updated in the isolated tree.
> 
> It works with a patch similar to the one attached to bug #232141. I'm still
> not sure it's worth rewriting all the tests to make them async when we can
> just notify earlier about property changes.

Unfortunately I think we have no choice and have to make the tests async. See my comment in https://bugs.webkit.org/show_bug.cgi?id=232141.