Bug 232274 - external/wpt/css/css-tables/tentative/colspan-redistribution.html failing on Safari and Webkit
Summary: external/wpt/css/css-tables/tentative/colspan-redistribution.html failing on ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 14:39 PDT by aanala
Modified: 2023-10-21 06:34 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description aanala 2021-10-25 14:39:15 PDT 
Below wpt test is failing on Safari and Webkit

external/wpt/css/css-tables/tentative/colspan-redistribution.html

https://crrev.com/888473
Cl: https://chromium-review.googlesource.com/c/chromium/src/+/2935771

Chromium Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1214206

Mozilla test failure bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1650712
Comment 1 Radar WebKit Bug Importer 2021-11-01 14:40:31 PDT 
<rdar://problem/84899911>
Comment 3 Ahmad Saleem 2023-10-21 06:34:01 PDT 
Merging Blink Commit:

columnMaxLogicalWidth = std::max(columnMaxLogicalWidth, columnMinLogicalWidth);
                    m_layoutStruct[pos].effectiveMaxLogicalWidth = std::max(m_layoutStruct[pos].effectiveMaxLogicalWidth, columnMaxLogicalWidth);

Here: https://github.com/WebKit/WebKit/blob/2eed0466d7087a67e3b65404c23d3e1622e6ae15/Source/WebCore/rendering/AutoTableLayout.cpp#L430

__

It does not progress below test case though, we might have other issue in handling colspan, which we might need to fix before doing this.