Bug 232259 - [macOS][GPUP] Block access to mach register
Summary: [macOS][GPUP] Block access to mach register
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 12:04 PDT by Per Arne Vollan
Modified: 2021-11-12 12:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2021-10-25 12:06 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.79 KB, patch)
2021-11-12 08:38 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-10-25 12:04:33 PDT 
Based on telemetry, block access to mach register in the GPU process on macOS.
Comment 1 Radar WebKit Bug Importer 2021-10-25 12:05:16 PDT 
<rdar://problem/84624488>
Comment 2 Per Arne Vollan 2021-10-25 12:06:11 PDT 
Created attachment 442392 [details]
Patch
Comment 3 Brent Fulgham 2021-10-25 12:10:29 PDT 
Comment on attachment 442392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442392&action=review

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690
> -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))

I think this is needed for profiling GL content in the GPU Process. I'm not sure it's safe to remove, unless you have tested using the graphics tools on the GPU Process.
Comment 4 Per Arne Vollan 2021-11-12 08:38:16 PST 
Created attachment 444072 [details]
Patch
Comment 5 Per Arne Vollan 2021-11-12 08:39:46 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 442392 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442392&action=review
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690
> > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))
> 
> I think this is needed for profiling GL content in the GPU Process. I'm not
> sure it's safe to remove, unless you have tested using the graphics tools on
> the GPU Process.

That is a good point. I kept this rule for internal builds, which is the way we've done it in the WebContent process.

Thanks for reviewing!
Comment 6 Brent Fulgham 2021-11-12 09:31:58 PST 
Comment on attachment 444072 [details]
Patch

r=me
Comment 7 EWS 2021-11-12 12:09:20 PST 
Committed r285735 (244194@main): <https://commits.webkit.org/244194@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444072 [details].