RESOLVED FIXED 232259
[macOS][GPUP] Block access to mach register 
https://bugs.webkit.org/show_bug.cgi?id=232259
Summary [macOS][GPUP] Block access to mach register
Per Arne Vollan
Reported 2021-10-25 12:04:33 PDT
Based on telemetry, block access to mach register in the GPU process on macOS.
Attachments
Patch (1.83 KB, patch)
2021-10-25 12:06 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2021-11-12 08:38 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-25 12:05:16 PDT
<rdar://problem/84624488>
Per Arne Vollan
Comment 2 2021-10-25 12:06:11 PDT
Created attachment 442392 [details] Patch
Brent Fulgham
Comment 3 2021-10-25 12:10:29 PDT
Comment on attachment 442392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442392&action=review > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) I think this is needed for profiling GL content in the GPU Process. I'm not sure it's safe to remove, unless you have tested using the graphics tools on the GPU Process.
Per Arne Vollan
Comment 4 2021-11-12 08:38:16 PST
Created attachment 444072 [details] Patch
Per Arne Vollan
Comment 5 2021-11-12 08:39:46 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 442392 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442392&action=review > > > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) > > I think this is needed for profiling GL content in the GPU Process. I'm not > sure it's safe to remove, unless you have tested using the graphics tools on > the GPU Process. That is a good point. I kept this rule for internal builds, which is the way we've done it in the WebContent process. Thanks for reviewing!
Brent Fulgham
Comment 6 2021-11-12 09:31:58 PST
Comment on attachment 444072 [details] Patch r=me
EWS
Comment 7 2021-11-12 12:09:20 PST
Committed r285735 (244194@main): <https://commits.webkit.org/244194@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444072 [details].
Note You need to log in before you can comment on or make changes to this bug.