Bug 232246 - Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
Summary: Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 10:25 PDT by Antoine Quint
Modified: 2021-10-26 00:07 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.84 KB, patch)
2021-10-25 10:26 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-10-25 10:25:19 PDT 
Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
Comment 1 Antoine Quint 2021-10-25 10:26:00 PDT 
Created attachment 442381 [details]
Patch
Comment 2 Dean Jackson 2021-10-25 10:27:43 PDT 
Comment on attachment 442381 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442381&action=review

> Source/WebCore/css/CSSToStyleMap.cpp:-461
> -        return;

Might as well keep the return and use "if" instead of "else if".
Comment 3 Antoine Quint 2021-10-25 10:28:53 PDT 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 442381 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442381&action=review
> 
> > Source/WebCore/css/CSSToStyleMap.cpp:-461
> > -        return;
> 
> Might as well keep the return and use "if" instead of "else if".

But it's one whole extra line of code!
Comment 4 EWS 2021-10-26 00:06:35 PDT 
Committed r284856 (243533@main): <https://commits.webkit.org/243533@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442381 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-26 00:07:19 PDT 
<rdar://problem/84650836>