Bug 232236 - [CSS Cascade Layers] Support 'revert-layer' value
Summary: [CSS Cascade Layers] Support 'revert-layer' value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on: 232829 232875 232876 234674
Blocks: 220779 234646
  Show dependency tree / graph
 
Reported: 2021-10-25 06:32 PDT by Antti Koivisto
Modified: 2021-12-24 15:20 PST (History)
10 users (show)

See Also:

Attachments
Patch (34.10 KB, patch)
2021-11-08 05:45 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (34.81 KB, patch)
2021-11-08 08:37 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (37.24 KB, patch)
2021-11-09 00:45 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (36.57 KB, patch)
2021-11-11 01:29 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (38.85 KB, patch)
2021-11-11 01:44 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-10-25 06:32:31 PDT 
https://www.w3.org/TR/css-cascade-5/#revert-layer
Comment 1 Radar WebKit Bug Importer 2021-11-01 06:33:17 PDT 
<rdar://problem/84879369>
Comment 2 Antti Koivisto 2021-11-08 05:45:21 PST 
Created attachment 443534 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-11-08 08:27:12 PST 
Comment on attachment 443534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443534&action=review

> Source/WebCore/style/CascadeLevel.h:39
> +inline CascadeLevel& operator--(CascadeLevel& level)

I wonder if it's worth giving this an explicit name.

> Source/WebCore/style/ElementRuleCollector.h:69
> +enum class FromStyleAttribute { No, Yes };

: bool ?
Comment 4 Antti Koivisto 2021-11-08 08:37:41 PST 
Created attachment 443551 [details]
Patch for landing
Comment 5 EWS 2021-11-08 09:21:03 PST 
Committed r285408 (243965@main): <https://commits.webkit.org/243965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443551 [details].
Comment 6 WebKit Commit Bot 2021-11-08 11:55:13 PST 
Re-opened since this is blocked by bug 232829
Comment 7 Antti Koivisto 2021-11-09 00:45:27 PST 
Created attachment 443658 [details]
Patch for landing
Comment 8 EWS 2021-11-09 01:29:50 PST 
Committed r285486 (244010@main): <https://commits.webkit.org/244010@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443658 [details].
Comment 9 WebKit Commit Bot 2021-11-09 05:49:55 PST 
Re-opened since this is blocked by bug 232875
Comment 10 Antti Koivisto 2021-11-09 06:02:49 PST 
Reverted in https://bugs.webkit.org/show_bug.cgi?id=232876
Comment 11 Tim Nguyen (:ntim) 2021-11-09 09:20:11 PST 
You probably want to re-apply https://github.com/WebKit/WebKit/commit/573122828aba14874cd08c2fab0f2e8e169345cd after once you land again.
Comment 12 Antti Koivisto 2021-11-11 01:29:07 PST 
Created attachment 443920 [details]
Patch
Comment 13 Antti Koivisto 2021-11-11 01:44:07 PST 
Created attachment 443921 [details]
Patch
Comment 14 EWS 2021-11-11 04:24:24 PST 
Committed r285624 (244125@main): <https://commits.webkit.org/244125@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443921 [details].