Bug 232226 - [WebCore] Remove unneeded WTF:: namespace prefix
Summary: [WebCore] Remove unneeded WTF:: namespace prefix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-24 21:35 PDT by Fujii Hironori
Modified: 2021-10-26 00:24 PDT (History)
60 users (show)

See Also:


Attachments
Patch (521.94 KB, patch)
2021-10-24 22:00 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (507.12 KB, patch)
2021-10-24 23:26 PDT, Fujii Hironori
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (507.20 KB, patch)
2021-10-25 00:06 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (503.05 KB, patch)
2021-10-25 13:58 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-10-24 21:35:29 PDT
[WebCore] Remove unneeded WTF:: namespace prefix
Comment 1 Fujii Hironori 2021-10-24 21:39:30 PDT
# There are Observer classes in WebCore
# There are a lot of declarations of WTF::TextStream in WebCore
git ls-files Source/WTF | grep \.h$ | xargs grep -h "using WTF:" | sort | uniq | grep -v WTF::Observer | grep -v WTF::TextStream > u.txt
perl -pe '$_ = "s/$&\\b/$2/g\n"  if ~/WTF(::\w+)?::(\w+)/' u.txt > u.sed
git ls-files Source/WebCore | grep -E '.(h|cpp|pl)'$ | xargs grep -l WTF:: | xargs sed -Ei -f u.sed

# Use WTF::append 
git co Source/WebCore/editing/TextIterator.cpp
Comment 2 Fujii Hironori 2021-10-24 22:00:54 PDT
Created attachment 442338 [details]
Patch
Comment 3 Fujii Hironori 2021-10-24 23:26:52 PDT
Created attachment 442339 [details]
Patch
Comment 4 Fujii Hironori 2021-10-25 00:06:45 PDT
Created attachment 442341 [details]
Patch
Comment 5 Myles C. Maxfield 2021-10-25 02:05:35 PDT
Comment on attachment 442341 [details]
Patch

Please don't land this until the tv and watch bots are green.
Comment 6 Fujii Hironori 2021-10-25 13:58:32 PDT
Created attachment 442411 [details]
Patch
Comment 7 Fujii Hironori 2021-10-25 23:47:37 PDT
Comment on attachment 442411 [details]
Patch

Thank you very much for the review.
Comment 8 EWS 2021-10-26 00:23:12 PDT
Committed r284857 (243534@main): <https://commits.webkit.org/243534@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442411 [details].
Comment 9 Radar WebKit Bug Importer 2021-10-26 00:24:21 PDT
<rdar://problem/84651234>