Bug 232223 - WTR / DRT should rely on SecurityOrigin::isLocalHostOrLoopbackIPAddress()
Summary: WTR / DRT should rely on SecurityOrigin::isLocalHostOrLoopbackIPAddress()
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-24 16:58 PDT by Alexey Shvayka
Modified: 2022-08-05 18:29 PDT (History)
10 users (show)

See Also:

Attachments
Patch (37.34 KB, patch)
2021-10-24 16:59 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (37.43 KB, patch)
2021-10-24 17:05 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (50.55 KB, patch)
2021-10-24 17:30 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (593.19 KB, patch)
2021-10-24 21:55 PDT, Alexey Shvayka 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-10-24 16:58:09 PDT 
WTR / DTR should rely on SecurityOrigin::isLocalHostOrLoopbackIPAddress()
Comment 1 Alexey Shvayka 2021-10-24 16:59:13 PDT 
Created attachment 442331 [details]
Patch
Comment 2 Alexey Shvayka 2021-10-24 17:05:55 PDT 
Created attachment 442332 [details]
Patch
Comment 3 EWS Watchlist 2021-10-24 17:06:56 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Alexey Shvayka 2021-10-24 17:30:27 PDT 
Created attachment 442333 [details]
Patch
Comment 5 Alexey Shvayka 2021-10-24 21:55:05 PDT 
Created attachment 442337 [details]
Patch
Comment 6 Geoffrey Garen 2021-10-27 10:50:05 PDT 
Comment on attachment 442337 [details]
Patch

Seems like the right approach. EWS is still failing.
Comment 7 Radar WebKit Bug Importer 2021-10-31 16:59:16 PDT 
<rdar://problem/84862800>
Comment 8 Alexey Shvayka 2022-08-05 18:29:50 PDT 
Closing this in favour of https://github.com/WebKit/WebKit/pull/2489, and also since my solution doesn't work on EWS.