Bug 232212 - Add an ImageDiff option to print out WPT-style pixel differences
Summary: Add an ImageDiff option to print out WPT-style pixel differences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 232201
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-23 20:58 PDT by Simon Fraser (smfr)
Modified: 2021-10-24 13:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.24 KB, patch)
2021-10-23 21:00 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-23 20:58:09 PDT 
Add an ImageDiff option to print out WPT-style pixel differences
Comment 1 Simon Fraser (smfr) 2021-10-23 21:00:35 PDT 
Created attachment 442291 [details]
Patch
Comment 2 Darin Adler 2021-10-23 22:05:00 PDT 
Comment on attachment 442291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442291&action=review

r=me even though this current version of the patch doesn’t apply yet

> Tools/ImageDiff/ImageDiff.cpp:52
> +static int processImages(std::unique_ptr<PlatformImage>&& actualImage, std::unique_ptr<PlatformImage>&& baselineImage, float tolerance, bool printDifferance)

There’s a spelling error here where difference has an a instead of an E. I recommend searching for “ifferance” and fixing them all.

> Tools/ImageDiff/ImageDiff.cpp:136
> +                "  -d, --difference      print WTP-style maxDifference and totalPixels data\n" \

I think we mean WPT not WTP
Comment 3 Simon Fraser (smfr) 2021-10-24 11:24:20 PDT 
https://trac.webkit.org/changeset/284764/webkit
Comment 4 Radar WebKit Bug Importer 2021-10-24 11:25:17 PDT 
<rdar://problem/84595508>