RESOLVED FIXED 232212
Add an ImageDiff option to print out WPT-style pixel differences 
https://bugs.webkit.org/show_bug.cgi?id=232212
Summary Add an ImageDiff option to print out WPT-style pixel differences
Simon Fraser (smfr)
Reported 2021-10-23 20:58:09 PDT
Add an ImageDiff option to print out WPT-style pixel differences
Attachments
Patch (12.24 KB, patch)
2021-10-23 21:00 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-10-23 21:00:35 PDT
Created attachment 442291 [details] Patch
Darin Adler
Comment 2 2021-10-23 22:05:00 PDT
Comment on attachment 442291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442291&action=review r=me even though this current version of the patch doesn’t apply yet > Tools/ImageDiff/ImageDiff.cpp:52 > +static int processImages(std::unique_ptr<PlatformImage>&& actualImage, std::unique_ptr<PlatformImage>&& baselineImage, float tolerance, bool printDifferance) There’s a spelling error here where difference has an a instead of an E. I recommend searching for “ifferance” and fixing them all. > Tools/ImageDiff/ImageDiff.cpp:136 > + " -d, --difference print WTP-style maxDifference and totalPixels data\n" \ I think we mean WPT not WTP
Simon Fraser (smfr)
Comment 3 2021-10-24 11:24:20 PDT
https://trac.webkit.org/changeset/284764/webkit
Radar WebKit Bug Importer
Comment 4 2021-10-24 11:25:17 PDT
<rdar://problem/84595508>
Note You need to log in before you can comment on or make changes to this bug.