Bug 23220 – Roll layoutDelta into layoutState

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

RenderView has the notion of "layoutDelta", which is an offset applied to repaint rects to account for objects which have been moved or resized during layout.

RenderView also maintains a LayoutState stack, which is a stack of cached offsets and clip rects used to optimize repainting.

layoutDelta should be merged with LayoutState.

We'd have to figure out what it means to disable layoutState though.

[Simon Fraser (smfr)]

Created attachment 26639 [details]
Patch, changelog

Comment on attachment 26639 [details]
Patch, changelog

> +    RenderView* v;
> +    if ((v = view()) && v->layoutStateEnabled()) {

Even though it increases the maximum indentation, I am not sure I like this change, because it moves v outside the scope of the if statement.

r=me

[Simon Fraser (smfr)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/LayoutState.cpp
	M	WebCore/rendering/LayoutState.h
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderBox.cpp
	M	WebCore/rendering/RenderFlexibleBox.cpp
	M	WebCore/rendering/RenderFlow.cpp
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderTableCell.cpp
	M	WebCore/rendering/RenderView.cpp
	M	WebCore/rendering/RenderView.h
	M	WebCore/rendering/bidi.cpp
Committed r39834