Bug 232191 – [LFC][IFC] Breaking before hyphen is only allowed when line-break is loose

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

The following breaks are allowed for loose line breaking if the preceding character belongs to the Unicode line breaking class ID [UAX14] (including when the preceding character is treated as ID due to word-break: break-all), and are otherwise forbidden:
breaks before hyphens:
‐ U+2010, – U+2013

https://drafts.csswg.org/css-text-3/#line-break-property

[zalan]

Created attachment 442245 [details]
Patch

[EWS]

Committed r284744 (243453@main): <https://commits.webkit.org/243453@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442245 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84580370>

[Darin Adler]

Comment on attachment 442245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442245&action=review

> Source/WTF/wtf/unicode/CharacterNames.h:64
> +constexpr UChar endash = 0x2013;

Typically we try to exactly follow the naming scheme from Unicode here, which I think would be enDash, two words.

[zalan]

(In reply to Darin Adler from comment #4)
> Comment on attachment 442245 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442245&action=review
> 
> > Source/WTF/wtf/unicode/CharacterNames.h:64
> > +constexpr UChar endash = 0x2013;
> 
> Typically we try to exactly follow the naming scheme from Unicode here,
> which I think would be enDash, two words.
Makes sense. Will change it. I was using the postscript name endash, see at  https://www.compart.com/en/unicode/U+2013

[zalan]

https://trac.webkit.org/changeset/284753/webkit