Fix issue for transform-origin in SVG
rdar://84516016
Created attachment 442235 [details] Patch
Comment on attachment 442235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442235&action=review > Source/WebCore/ChangeLog:3 > + Fix issue for transform-origin in SVG If this fixes an issue, that I expect to see a test, or a change in the expected results for an existing test
Created attachment 442401 [details] Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment on attachment 442401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442401&action=review r+ but the test needs fixing. > Source/WebCore/ChangeLog:3 > + Fix issue for transform-origin in SVG This should be more specific, like "transform-origin attribute ignored when using transform attribute in SVG" > Source/WebCore/ChangeLog:8 > + Add stopgap for C to use transform-origin in SVGGraphicsElement::animatedLocalTransform. Need to revise this. > Source/WebCore/ChangeLog:9 > + Better fix making transform a presentation attribute coming later. You could link to the bugzilla bug. > Source/WebCore/svg/SVGGraphicsElement.cpp:107 > + matrix.translate(-t.x(), -t.y()); Does translate(-t) work? > LayoutTests/imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style.svg:11 > + <rect x="0" y="0" width="40" height="10" style="fill:cyan" transform="scale(2, 3)" transform-origin="30px 10px"/> I think in the attribute you specify the transform-origin without units. Use fill="green" other than cyan fill. > LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/styling/render/transform-origin-not-explicit-style-expected.txt:1 > +layer at (0,0) size 800x600 These .txt files should not exist. The problem is that webkit testing doesn't find transform-origin-not-explicit-style-ref.svg as the ref (it would have to be named transform-origin-not-explicit-style-expected.svg); see webkit.org/b/203784
Created attachment 442404 [details] Fix for transform-origin in svg
Created attachment 442430 [details] Fix for transform-origin in svg
Committed r284853 (243530@main): <https://commits.webkit.org/243530@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442430 [details].