RESOLVED DUPLICATE of bug 232179 Bug 232183
RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet
https://bugs.webkit.org/show_bug.cgi?id=232183
Summary RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet
Wenson Hsieh
Reported 2021-10-22 15:52:45 PDT
SSIA
Attachments
Wenson Hsieh
Comment 1 2021-10-22 16:05:54 PDT
This bug tracks addressing https://bugs.webkit.org/show_bug.cgi?id=232113#c10, where the WeakHashSet `m_remoteDisplayLists` is accessed from both the rendering backend thread and the main thread in the GPU process. This is dangerous, given that WeakPtr itself cannot be used from different threads. We should make this a HashSet or HashMap of Ref/RefPtr, and then manually remove entries from this map when releasing cached image buffers.
Wenson Hsieh
Comment 2 2021-10-22 17:26:51 PDT
I think I'm going to fix this as a part of https://bugs.webkit.org/show_bug.cgi?id=232179, since both bugs can be addressed by very similar changes.
Wenson Hsieh
Comment 3 2021-10-22 17:27:06 PDT
*** This bug has been marked as a duplicate of bug 232179 ***
Note You need to log in before you can comment on or make changes to this bug.