Bug 232183 - RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet
Summary: RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet
Status: RESOLVED DUPLICATE of bug 232179
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-22 15:52 PDT by Wenson Hsieh
Modified: 2021-10-22 17:27 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-10-22 15:52:45 PDT 
SSIA
Comment 1 Wenson Hsieh 2021-10-22 16:05:54 PDT 
This bug tracks addressing https://bugs.webkit.org/show_bug.cgi?id=232113#c10, where the WeakHashSet `m_remoteDisplayLists` is accessed from both the rendering backend thread and the main thread in the GPU process.

This is dangerous, given that WeakPtr itself cannot be used from different threads.

We should make this a HashSet or HashMap of Ref/RefPtr, and then manually remove entries from this map when releasing cached image buffers.
Comment 2 Wenson Hsieh 2021-10-22 17:26:51 PDT 
I think I'm going to fix this as a part of https://bugs.webkit.org/show_bug.cgi?id=232179, since both bugs can be addressed by very similar changes.
Comment 3 Wenson Hsieh 2021-10-22 17:27:06 PDT 

*** This bug has been marked as a duplicate of bug 232179 ***