Bug 232174 - WebKit ought to be able to play videos without Content-Length HTTP header fields and without range support
Summary: WebKit ought to be able to play videos without Content-Length HTTP header fie...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-22 14:04 PDT by Alex Christensen
Modified: 2021-10-25 12:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.75 KB, patch)
2021-10-22 14:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.60 KB, patch)
2021-10-25 09:28 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-22 14:04:32 PDT 
WebKit ought to be able to play videos without Content-Length HTTP header fields and without range support
Comment 1 Alex Christensen 2021-10-22 14:17:10 PDT 
Created attachment 442199 [details]
Patch
Comment 2 Geoffrey Garen 2021-10-22 14:28:52 PDT 
Comment on attachment 442199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442199&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        AVFoundation doesn't like it when you give it a range like 0-1/* because it doesn't know the content length.
> +        To work around this, wait until the entire video is loaded then respond with a known length.
> +        This isn't great, but it's better than not playing the video at all.

So, was the old behavior a race condition based on how fast the video loaded? How did this every work at all?
Comment 3 Alex Christensen 2021-10-25 09:28:12 PDT 
Created attachment 442376 [details]
Patch
Comment 4 Alex Christensen 2021-10-25 09:28:25 PDT 
It never did work.
Comment 5 EWS 2021-10-25 12:25:33 PDT 
Committed r284816 (243508@main): <https://commits.webkit.org/243508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442376 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-25 12:26:20 PDT 
<rdar://problem/84625376>