Bug 232172 - Change Heap::writeBarrier() to do the cheaper check first.
Summary: Change Heap::writeBarrier() to do the cheaper check first.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-22 13:53 PDT by Mark Lam
Modified: 2021-10-22 14:48 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.34 KB, patch)
2021-10-22 13:55 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-10-22 13:53:05 PDT 
It's cheaper to do a check using incoming args (which are already loaded in registers) than to do a check which requires memory loads.
Comment 1 Mark Lam 2021-10-22 13:55:18 PDT 
Created attachment 442195 [details]
proposed patch.
Comment 2 Robin Morisset 2021-10-22 13:57:16 PDT 
Comment on attachment 442195 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2021-10-22 14:00:59 PDT 
Comment on attachment 442195 [details]
proposed patch.

Thanks for the review.
Comment 4 EWS 2021-10-22 14:47:41 PDT 
Committed r284715 (243430@main): <https://commits.webkit.org/243430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442195 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-22 14:48:20 PDT 
<rdar://problem/84564524>